Repository navigation
π fix: align standby qualification with dispatch queue - #16436
mrbobbytables wants to merge 2 commits into
Conversation
Use the dispatchable admission queue and exact lane assignment when computing standby qualification counts. Hive-Run: hivecommons#16420 Hive-Plan: standby-contributors Hive-Spec: standby-contributors#S7 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Document that qualified standby counts use the dispatchable queue and exact lane assignment. Hive-Run: hivecommons#16420 Hive-Plan: standby-contributors Hive-Spec: standby-contributors#S7 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Intent alignment (read at head 7511fe1): the diff does what #16420 asked via the issue's own third option β standbyLaneItems now reads the dispatchable admission queue and applies the identical Held / EqualFold(TrimSpace(Lane)) filter that standbyDispatchItem uses (src/pkg/dashboard/contribute_ws.go:3147-3149 vs contribute_standby_dispatch.go:198-209), so "M qualify" can no longer name a contributor for an item the lane cannot dispatch. No lock hazard: UpdateStatusIfFresh holds no statusMu at the call (server.go:2426-2434) and admissionQueueSnapshot only RLocks it (contribute_sse.go:305-307). Two advisory notes, neither blocking:
-
"N waiting" and "M qualify" now come from different splits.
lane_queue_depthsis untouched (status_builder.gobuildLaneQueueDepths), so the issue's exact scenario now rendersscanner: 1 waiting, 0 qualifyβ the item is still shown as waiting on a lane that can't dispatch it. The issue accepted this trade-off ("standby could use the admission queue's lane instead of reusing that depth") and the S7 doc edit (src/docs/design/standby-contributors.md:725-728) states it, so this is backlog, not a blocker. -
One-refresh lag.
admissionQueueSnapshotreadsh.server.statusβ the previously published snapshot β not thestatusbeing built (contribute_sse.go:305-311), soqualified_standbysreflects the prior refresh's repo list and is0on the very first publish. Dispatch reads the same source, so tile and dispatch still agree; just noting the source differs from the rest of the payload.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Correctness review @ 7511fe1 β the diff is internally consistent ( 1.
|
|
@mrbobbytables this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Summary
Make the standby tile qualify contributors against the same dispatchable admission queue standby dispatch reads, filtering to the exact lane and excluding held items. Add regression coverage and clarify the S7 design note.
Related issues
Fixes #16420
Testing
gofmtformatting check (passed);git diff --check(passed).Contributor checklist
src/code changes, or CI fails): addedchangelog.d/fixed-16420-standby-lane-count.mdcontaining one-bullet.v6for this dashboard-optional-operation issue).π fix: ....git commit -s).β hive: backend=copilot model=gpt-6-luna