Repository navigation
✨ feat(attention): status-card Attention section, per-repo tracking issue and 24h reminder policy - #16386
Conversation
…ssue and 24h reminder policy Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#16386cd7bac0` sha256:4d925b2deeb5d703b6b116429110fdfbf53f15ad4b8732a8565959bba2f0057c — download from the dashboard or `hivectl review evidence #16386`. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
…ation IssueListByRepoOptions embeds both ListCursorOptions and ListOptions, so opts.Page is an ambiguous selector and the package failed to compile. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Read against v5 with the existing attention/prstatus code open. Looks correct to me; no defects found. What I verified:
- Section key and clearing.
SweepAttentionQueuewrites/clears the"attention"section, the same key the existing writers use (attention.go:55,attention_command.go:83). Clearing with""works becauseprstatus.Upsertdrops a section whose text is empty (prstatus/prstatus.go:99-101), andattentionStatusreturning""atactive == 0is behaviour-preserving — onv5the builder is already empty in that case since resolved episodes are skipped (attention.go:120-123). - Gating. The pass is a no-op unless
attentionPilot()is on andcfg.Owner(repo) == attentionHiveID(attention_queue.go, top ofSweepAttentionQueue); archived repos are skipped in the un-park loop. The reminder comment goes throughWritebackAllowed(KindNeedsDecisionComment)thenCreateIssueComment, and is registered innotification_write_sites.gounderremindAttention. The tracking issue goes throughWritebackAllowed(KindIssueFile), is created only whenexisting == nil && len(open) > 0, is found by marker + origin label + own-account check (so a squatted title is not adopted), and a closed one is left alone — matching the recommendations-issue pattern the body cites. - Recipient-action suppression.
recipientActedAtuses the existingIssueTimelineSince(issue_timeline.go:39) forcommented/labeled/unlabeledand pagesListReviewsfor PRs since the timeline omits reviews;RecordRecipientActiononly moves the clock forward. Team recipients (org/team) are correctly treated as unattributable byRecipientLogin. - Body vs diff. "Reminders never touch reviewers" holds — there is no review-request call anywhere in the diff. The 24h default and ack/snooze/action semantics match what the body attributes to #16075, so I am not raising a decision question on the human-notification side effect.
mobile-shots is the only red check on this head; nothing in the diff touches the dashboard UI it renders.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Chrome helper processes can keep writing to the scratch user-data-dir after the browser exits, so rmSync raced ENOTEMPTY on Default/ and the throw inside finally failed the run and skipped writing the overflow report. Retry longer, warn instead of throwing, and write the report files before tearing Chrome down. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Intent-alignment (delta re-review, head a4d17b2) — approve.
The delta since 0ba464e is a merge of origin/v5 (#16188, #16377) plus two PR-authored changes the PR body does not mention:
src/scripts/dashboard-mobile-shots.mjs:245-253,374-378— wrapsrmSync(PROFILE_DIR)in try/warn and writes the report files beforecleanup(). This is unrelated to #16362; it unblocks themobile-shotscheck, which failed at 0ba464e withENOTEMPTY ... /.chrome-dashboard-mobile-shots/Default(run 41581518951), a pre-existing flake on v5. Fix looks correct..github/scripts/integration-governance.cjs:12— re-pinsTRUSTED_SCRIPTS_TREEtof106bf6d…, which matchesHEAD:src/scriptsat this head (required by the check at:101-104).
Advisory: add one line to the PR body noting the bundled mobile-shots flake fix and the governance re-pin, so the merged description matches the diff. Not blocking.
— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88
After #16366 only this hive's own App login owns the hive status comment, so the attention-queue fixture must identify as hive-app[bot] for the closure pass to clear the Attention section in place. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Why
The attention pilot (#16270) already pages a person once when an episode becomes actionable, and
/hive ack//hive snoozerecord reminder state. But nothing used that state yet. An ask that was paged once and then ignored just went quiet. There was no single place to see what is waiting on whom. And when an item closed, its episodes stayed open in the ledger, so a later pass could still nag about it. #16075 asked for three things: a 24h reminder that respects ack, snooze and recipient action; a GitHub-native action queue; and no stale asks after closure. This PR adds them under the existing opt-in flag. It reuses the existing episode store, ack/snooze state and single status writer. It does not add a second writer path.CreateIssueCommentafter the write-back gate allows it, so shadow mode counts it under its own producer (remindAttention). After each reminder the card is refreshed throughprstatus.Write. The interval is counted from the page, the last reminder or the recipient's last action (comment, review or label change), whichever is latest. That way a person who just engaged is not pinged. Reminders never touch reviewers, so a review request owned by GitHub, CODEOWNERS or Prow is never duplicated.attentionsection now has an "Attention — who owes what" heading. Each line shows when the ask started, any snooze deadline and how many reminders were sent. Each repo also gets one tracking issue. It follows the recommendations-issue pattern: it is created once, and creating it is the only notifying write. After that it is edited only when the list changes. Item references are code spans and logins are neutralised, so an edit never mentions or cross-references anyone. Closing an item resolves its episodes, removes its Attention section and drops it from the queue.issueAttentionAllowednow usessafeGetLogin/issueLabelNames. The new reminder gate builds itswriteback.Itemthe same way.The pass runs from the un-park sweep right after that pass's ack/snooze replies. It does nothing unless
attention_pilotis on and this hive is the repo's admitter. The new interval key isgithub.attention.reminder_interval(default 24h). Edits to the files that #16351 and #16366 also touch are one-line additions or appended sections.Not included: the Actions-workflow migration (#16363).
Closes #16362
Closes #16361
Closes #16376
Part of #16270 (epic tracker; remaining child #16363 is the Actions-workflow migration)
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88