Skip to content

✨ feat(attention): status-card Attention section, per-repo tracking issue and 24h reminder policy - #16386

Merged
hivecommons-hive[bot] merged 7 commits into
v5from
scanner/fix-16362
Nov 3, 2026
Merged

hivecommons-hive[bot] merged 7 commits into
v5from
scanner/fix-16362

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Why

The attention pilot (#16270) already pages a person once when an episode becomes actionable, and /hive ack / /hive snooze record reminder state. But nothing used that state yet. An ask that was paged once and then ignored just went quiet. There was no single place to see what is waiting on whom. And when an item closed, its episodes stayed open in the ledger, so a later pass could still nag about it. #16075 asked for three things: a 24h reminder that respects ack, snooze and recipient action; a GitHub-native action queue; and no stale asks after closure. This PR adds them under the existing opt-in flag. It reuses the existing episode store, ack/snooze state and single status writer. It does not add a second writer path.

The pass runs from the un-park sweep right after that pass's ack/snooze replies. It does nothing unless attention_pilot is on and this hive is the repo's admitter. The new interval key is github.attention.reminder_interval (default 24h). Edits to the files that #16351 and #16366 also touch are one-line additions or appended sections.

Not included: the Actions-workflow migration (#16363).

Closes #16362
Closes #16361
Closes #16376
Part of #16270 (epic tracker; remaining child #16363 is the Actions-workflow migration)

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…ssue and 24h reminder policy

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 3, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: a4d17b2

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#16386cd7bac0` sha256:4d925b2deeb5d703b6b116429110fdfbf53f15ad4b8732a8565959bba2f0057c — download from the dashboard or `hivectl review evidence #16386`.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16385 ✨ feat(notifications): refs sweep defers to the hive:status card; document Actions comment deduplication CONFLICT .github/scripts/integration-governance.cjs
src/docs/notifications.md
#16396 🐛 fix(automerge): gate normal-mode stage-note comments same files src/docs/notifications.md
#16395 ✨ feat(notifications): skip already-pending reviewers in request_review relay same files src/docs/notifications.md

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 3, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026
…ation

IssueListByRepoOptions embeds both ListCursorOptions and ListOptions, so
opts.Page is an ambiguous selector and the package failed to compile.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against v5 with the existing attention/prstatus code open. Looks correct to me; no defects found. What I verified:

  • Section key and clearing. SweepAttentionQueue writes/clears the "attention" section, the same key the existing writers use (attention.go:55, attention_command.go:83). Clearing with "" works because prstatus.Upsert drops a section whose text is empty (prstatus/prstatus.go:99-101), and attentionStatus returning "" at active == 0 is behaviour-preserving — on v5 the builder is already empty in that case since resolved episodes are skipped (attention.go:120-123).
  • Gating. The pass is a no-op unless attentionPilot() is on and cfg.Owner(repo) == attentionHiveID (attention_queue.go, top of SweepAttentionQueue); archived repos are skipped in the un-park loop. The reminder comment goes through WritebackAllowed(KindNeedsDecisionComment) then CreateIssueComment, and is registered in notification_write_sites.go under remindAttention. The tracking issue goes through WritebackAllowed(KindIssueFile), is created only when existing == nil && len(open) > 0, is found by marker + origin label + own-account check (so a squatted title is not adopted), and a closed one is left alone — matching the recommendations-issue pattern the body cites.
  • Recipient-action suppression. recipientActedAt uses the existing IssueTimelineSince (issue_timeline.go:39) for commented/labeled/unlabeled and pages ListReviews for PRs since the timeline omits reviews; RecordRecipientAction only moves the clock forward. Team recipients (org/team) are correctly treated as unattributable by RecipientLogin.
  • Body vs diff. "Reminders never touch reviewers" holds — there is no review-request call anywhere in the diff. The 24h default and ack/snooze/action semantics match what the body attributes to #16075, so I am not raising a decision question on the human-notification side effect.

mobile-shots is the only red check on this head; nothing in the diff touches the dashboard UI it renders.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Chrome helper processes can keep writing to the scratch user-data-dir
after the browser exits, so rmSync raced ENOTEMPTY on Default/ and the
throw inside finally failed the run and skipped writing the overflow
report. Retry longer, warn instead of throwing, and write the report
files before tearing Chrome down.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 3, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent-alignment (delta re-review, head a4d17b2) — approve.

The delta since 0ba464e is a merge of origin/v5 (#16188, #16377) plus two PR-authored changes the PR body does not mention:

  • src/scripts/dashboard-mobile-shots.mjs:245-253,374-378 — wraps rmSync(PROFILE_DIR) in try/warn and writes the report files before cleanup(). This is unrelated to #16362; it unblocks the mobile-shots check, which failed at 0ba464e with ENOTEMPTY ... /.chrome-dashboard-mobile-shots/Default (run 41581518951), a pre-existing flake on v5. Fix looks correct.
  • .github/scripts/integration-governance.cjs:12 — re-pins TRUSTED_SCRIPTS_TREE to f106bf6d…, which matches HEAD:src/scripts at this head (required by the check at :101-104).

Advisory: add one line to the PR body noting the bundled mobile-shots flake fix and the governance re-pin, so the merged description matches the diff. Not blocking.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026
After #16366 only this hive's own App login owns the hive status comment,
so the attention-queue fixture must identify as hive-app[bot] for the
closure pass to clear the Attention section in place.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 3, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 4388211 into v5 Nov 3, 2026
97 of 106 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16362 branch November 3, 2026 07:20
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started)

Projects

None yet

0 participants