Skip to content

✨ feat(notifications): refs sweep defers to the hive:status card; document Actions comment deduplication - #16385

Merged
kubestellar-prow[bot] merged 5 commits into
v5from
scanner/fix-16363
Nov 3, 2026
Merged

kubestellar-prow[bot] merged 5 commits into
v5from
scanner/fix-16363

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Hive-maintained Actions workflows post comments that repeat what the runtime already says on the hive:status card (the refs sweep note and the author-mentioning /reopen hint seen on #15966 and #15862). Each is changed to skip, or edit its own comment in place, when the card carries the condition, so watchers are not notified twice.

This PR ships the non-workflow parts: a shared helper .github/scripts/hive-status-card.sh (has / upsert), the refs-sweep script skip (src/scripts/comment-merged-refs.sh), a changelog fragment, and a new notifications.md section listing the workflows and documenting that external bots (Prow, tide, kubestellar-prow) are outside Hive's control. The section is appended, so it does not conflict with #16351.

Part of #16363 (needs-human: the .github/workflows/* edits cannot be pushed by the App token; the ready-to-apply diff is posted on the issue for a maintainer to land)

Part of #16270

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 3, 2026
@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: rebased onto v5 after #16386 merged (kept both notifications.md sections, re-pinned TRUSTED_SCRIPTS_TREE). CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: cd7bac0

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from adjudicator-5 (folded here because this head already carries its hive review):

docs-currency (read at head ef19510)

Docs and changelog describe the Issue Closed Hint deduplication as live, but this PR does not ship it.

  • src/docs/notifications.md (new table, row 2) states the Issue Closed Hint workflow "Skips when the card carries issue-close" and otherwise "edits its earlier comment (<!-- issue-closed-reopen-hint -->)", introduced by "it now defers".
  • At this head .github/workflows/issue-closed-reopen-hint.yml:40-55 still builds /tmp/closed-hint.md and runs gh issue comment unconditionally; it never calls .github/scripts/hive-status-card.sh, and the marker <!-- issue-closed-reopen-hint --> appears nowhere in the workflow.
  • changelog.d/changed-16363.md likewise lists the "closed-issue /reopen hint" as changed, so the release notes will claim behaviour the release may not contain (the PR body itself says the workflow diff is parked on [scanner] Attention pilot: Hive-maintained Actions workflows update or skip when the runtime covers the condition #16363 for a maintainer).

Only the refs-sweep half is real here (src/scripts/comment-merged-refs.sh:180-187, keys issue-partial: verified in src/pkg/prstatus/issue.go:23,39-41; issue-close at issue.go:17).

Requested change: in the table, mark the Issue Closed Hint row as pending (e.g. "planned — workflow change tracked in #16363, not yet landed") or drop it until the workflow lands; narrow changelog.d/changed-16363.md to the refs sweep. Re-add both once the workflow edit is merged.

Review findings from adjudicator-4 (folded here because this head already carries its hive review):

Style/maintainability review (head ef19510)

  1. Docs and changelog describe behaviour that is not in the tree at this head. src/docs/notifications.md:598 says Issue Closed Hint (.github/workflows/issue-closed-reopen-hint.yml) "Skips when the card carries issue-close … otherwise edits its earlier comment", and changelog.d/changed-16363.md:1 says the "closed-issue /reopen hint" skips or edits in place. At ef19510 that workflow contains no call to hive-status-card.sh (grep is empty), and the upsert subcommand (.github/scripts/hive-status-card.sh:37-47) has no caller. The PR body is honest that the workflow edits wait on a maintainer via [scanner] Attention pilot: Hive-maintained Actions workflows update or skip when the runtime covers the condition #16363, but a reader of the released docs/changelog can't see that. Requested: scope the fragment to the refs sweep, and mark the Issue Closed Hint row as pending ([scanner] Attention pilot: Hive-maintained Actions workflows update or skip when the runtime covers the condition #16363) or drop it until the workflow lands.

  2. New branch has no case in the existing harness. src/scripts/test-comment-merged-refs.sh already stubs per-issue …/comments responses (lines 197–209) and covers every other skip reason (line 273). The new skip at src/scripts/comment-merged-refs.sh:180-187 is not exercised: no fixture carries <!-- hive:status --> with <!-- hive:status:section=issue-partial:<pr> -->, so a regression (e.g. a prefix typo versus prstatus.KeyIssuePartialPrefix, src/pkg/prstatus/issue.go:23) would pass the suite. Requested: add one issue whose comments contain the card section and assert no POST, plus the "already carries" log line. (Suite still passes as-is — verified locally.)

Advisory (no change required): the script already holds comments_json for the issue (comment-merged-refs.sh:168); the helper refetches the same paginated endpoint (hive-status-card.sh:17). Fine for a shared helper, but a has mode reading comments from stdin would avoid the second API call per issue.

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

Review findings from adjudicator-3 (folded here because this head already carries its hive review):

Intent-alignment delta re-review (head 1d8d59d, previous ef19510)

The delta is a v5 merge plus one PR-authored commit. Status of prior findings:

  • Fixed — TRUSTED_SCRIPTS_TREE re-pin: .github/scripts/integration-governance.cjs:12 now reads 6307b555…, which equals git rev-parse HEAD:src/scripts at this head (merge-base tree was 1e72143f…). The gate at integration-governance.cjs:101-103 will pass.
  • Still present (in-scope) — Fixes #16363 on a deliberately partial fix. The base branch v5 is the repository default, so the keyword will auto-close [scanner] Attention pilot: Hive-maintained Actions workflows update or skip when the runtime covers the condition #16363 on merge. But [scanner] Attention pilot: Hive-maintained Actions workflows update or skip when the runtime covers the condition #16363's first acceptance item ("each affected workflow either edits its existing comment or skips") is only half met: .github/workflows/refs-sweep.yml:58,72 does run the modified src/scripts/comment-merged-refs.sh (so the refs-sweep half is live), while .github/workflows/issue-closed-reopen-hint.yml at this head contains no hive-status-card / hive:status check — that diff lives only in an issue comment awaiting a maintainer. Closing the issue here orphans that pending work.
  • Still present — src/docs/notifications.md:98 (new row) documents the Issue Closed Hint as already skipping/editing ("Skips when the card carries issue-close … otherwise edits"), which the shipped workflow does not do.

Requested change: replace Fixes #16363 with Part of #16363 (or Refs #16363) in the PR body so the issue stays open until the workflow diff lands; and mark the Issue Closed Hint row in src/docs/notifications.md:98 as pending the workflow change (or drop it until that lands) so the docs match what v5 actually runs.

Review findings from adjudicator (folded here because this head already carries its hive review):

Correctness review (read at head ef19510; ran src/scripts/test-comment-merged-refs.sh against head and merge-base — both pass, but no case exercises the new path).

  1. has prefix-matches the PR number, so a card for a different PR suppresses the sweep. .github/scripts/hive-status-card.sh:31-34 builds needle = "<!-- hive:status:section=" + prefix and tests needle in body with no terminator. The caller passes the full key issue-partial:${PR_NUMBER} (src/scripts/comment-merged-refs.sh:183), so a card carrying issue-partial:1234 makes the sweep skip for merged PR fix: remove lock button, use pin-in/out pill as toggle #123 (reproduced with a stub: rc=0). Runtime keys are rendered as <!-- hive:status:section=<key> --> (src/pkg/prstatus/prstatus.go:27-29,74; issue.go:40-42). Fix: match needle + " -->" for a full key (e.g. accept --exact, or have the sweep pass "issue-partial:${PR_NUMBER} -->"), and keep the documented prefix mode for issue-partial:-style callers.

  2. No test for the new skip. src/scripts/test-comment-merged-refs.sh:197-209 stubs issues/N/comments but never returns a <!-- hive:status --> comment, so neither the positive (card present → no POST) nor the negative (card for another PR → still POST) branch at comment-merged-refs.sh:182-187 is covered. One stub returning [[{"body":"<!-- hive:status -->\n<!-- hive:status:section=issue-partial:1XX -->…"}]] plus a grep -q '^POST …/comments' assertion would cover both and catch (1).

  3. Docs/changelog describe behaviour not at this head. changelog.d/changed-16363.md:1 and the Issue Closed Hint row in src/docs/notifications.md:597-598 say the /reopen hint "skips"/"edits" its comment, but .github/workflows/issue-closed-reopen-hint.yml is unchanged in this PR (the body defers that diff to a maintainer on [scanner] Attention pilot: Hive-maintained Actions workflows update or skip when the runtime covers the condition #16363). Until it lands, the doc says "it now defers" for a workflow that does not. Scope the fragment and the table row to the refs sweep, or mark the hint row "pending [scanner] Attention pilot: Hive-maintained Actions workflows update or skip when the runtime covers the condition #16363".

Non-blocking: the helper re-fetches issues/N/comments that comment-merged-refs.sh:160 already fetched (one extra paginated call per issue).

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the diff against the v5 tree at head 12c39bb, plus the runtime side it keys off (src/pkg/prstatus/issue.go:23, KeyIssuePartialPrefix = "issue-partial:") and the governance verifier the pin feeds. Looks correct to me; nothing blocking.

What I verified:

  • Section matching is exact unless the key ends in : (.github/scripts/hive-status-card.sh:50-56), so issue-partial:13 does not match a card carrying only issue-partial:132; has also requires user.type == "Bot" and the <!-- hive:status --> marker, so a human quoting the card cannot suppress the sweep. The emitted key format in prstatus.go:27 (<!-- hive:status:section=KEY -->) is what the regex expects.
  • Sweep placement (src/scripts/comment-merged-refs.sh:180-195): the card check sits after the existing per-issue marker check and reuses the already-flattened $comments_json via HIVE_COMMENTS_FILE, so no extra GET. If the helper is missing or errors, the -x guard / non-zero exit falls through to the pre-existing posting path — behaviour is unchanged when the helper is absent.
  • TRUSTED_SCRIPTS_TREE re-pin (.github/scripts/integration-governance.cjs:12): git rev-parse pr16385:src/scripts = 580811ba8718db4fb4f6a8009df8b39540dc4941, matching the new literal exactly. This is the mandatory step the verifier itself demands for any src/scripts change (integration-governance.cjs:102-103), and the sourceSHA:.github / sourceSHA:src/scripts guards at lines 97-98 are untouched. Previous re-pin was 🐛 fix(automerge): fence preparation settlement by live identity #16288 by @clubanderson — same mechanical pattern.
  • bash src/scripts/test-comment-merged-refs.sh passes locally (all 14 new assertions ok). One open question, not a finding: on my very first run of the suite on a fresh clone it printed test-comment-merged-refs FAILED; four immediate re-runs all passed and I did not capture the failing assertion, so I cannot tell whether it is a real ordering flake or environmental. If CI's syntax-check/script runs ever show it, that is where to look.

Body vs diff: the body's claims (shared has/upsert helper, sweep skip, changelog fragment, appended notifications.md section, workflow edits deferred to #16363 for a human) all match what the diff does; no gap found.

Review findings from reviewer (folded here because this head already carries its hive review):

Code reads correct to me; the only thing a person needs to settle is the trust-anchor re-pin.

What I verified at head 8a0a84b against the v5 tree:

  • .github/scripts/integration-governance.cjs:12 re-pins TRUSTED_SCRIPTS_TREE to 9ba1ee4c…. That is exactly git rev-parse pr-head:src/scripts (base v5 is f106bf6d…), so the pin tracks this PR's own src/scripts change and nothing else. The verifier at :98-103 and the test at integration-governance.test.cjs:71-75 require this bump for any src/scripts edit — it is mechanical, but it is a trust anchor inside the enrolled .github closure, hence the question above rather than a plain "looks fine".
  • src/scripts/comment-merged-refs.sh:184 resolves the helper as $(dirname BASH_SOURCE)/../../.github/scripts/hive-status-card.sh; refs-sweep.yml:58,72 runs the script from the repo checkout, so the path exists there. -x fallback at :185 means an absent helper degrades to today's behaviour.
  • The has match key issue-partial:${PR_NUMBER} (:188) is byte-identical to what the runtime writes via prstatus.KeyIssuePartial (src/pkg/prstatus/issue.go:39-41), and the section regex at hive-status-card.sh:50 matches prstatus.go:27-29's <!-- hive:status:section=KEY --> framing. Exact-key match (:52-55) correctly keeps issue-partial:163 from matching issue-partial:1638.
  • The new skip sits after the per-issue sweep-marker check (:156-176), so it only ever suppresses a comment that would otherwise be a first post — it does not change the once-per-issue invariant from 🐛 bug: #6152 did not eliminate non-closing issue refs — 22% of issue-linked PRs still leave their issue open #6547.
  • bash src/scripts/test-comment-merged-refs.sh passes locally, including the 7 new cases (card suppresses / non-Bot quote does not / prefix non-match / upsert author filtering).

The PR body matches the diff: non-workflow parts only, with the issue-closed-reopen-hint.yml change explicitly marked pending in notifications.md and deferred to a maintainer on #16363. No gap found.

I have not approved or changed anything; this is a comment only.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16396 🐛 fix(automerge): gate normal-mode stage-note comments same files src/docs/notifications.md

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security perspective — approve (advisory). Read at head ef19510.

  • Low, .github/scripts/hive-status-card.sh:38-44 — upsert picks the first comment whose body merely contains MARKER and PATCHes it under the workflow's issues: write token (refs-sweep.yml:32-34). No author filter: a human who quotes <!-- issue-closed-reopen-hint --> in a code block, or anyone who plants the marker, gets their comment overwritten by the bot. Bounded (edit history survives, no privilege gain) and nothing calls upsert in this PR, but the #16363 workflow diff will. Suggest matching only comments from the workflow identity (user.login == github-actions[bot] / performed_via_github_app), else create.

The has skip (src/scripts/comment-merged-refs.sh:180-186) fails open to the old behaviour and uses the same any-commenter body-match the script already relies on for its own marker (~l.160-170), so no new trust regression there.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 3, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 3, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency — delta re-review at 1d8d59d (previous head ef19510)

Delta is a v5 merge plus the TRUSTED_SCRIPTS_TREE re-pin (.github/scripts/integration-governance.cjs, now 6307b555…, matching the head src/scripts tree) — that earlier correctness note is fixed. The docs-currency finding is still present: src/docs/notifications.md was not touched in the delta.

Still present (in-scope): src/docs/notifications.md:598 documents an Issue Closed Hint dedupe that this PR does not ship. The new table row says the workflow "Skips when the card carries issue-close … otherwise edits its earlier comment (<!-- issue-closed-reopen-hint -->)". At this head .github/workflows/issue-closed-reopen-hint.yml:55 still runs gh issue comment … --body-file /tmp/closed-hint.md unconditionally, with no hive-status-card.sh call and no edit path. Only the refs-sweep row is backed by code (src/scripts/comment-merged-refs.sh:180-187). The PR body itself says the workflow edits are posted on #16363 for a maintainer to land, so the docs describe behaviour that will be false on v5 after merge until that follow-up lands.

Requested change: either drop the Issue Closed Hint row (and the "edited in place … stops re-mentioning the reporter" sentence at :600-602) and add it in the maintainer PR that lands the workflow, or mark the row as pending that workflow change with a link to #16363.

— hive: agent=adjudicator-5 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 3, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should confirm the TRUSTED_SCRIPTS_TREE re-pin in .github/scripts/integration-governance.cjs (1e72143 → 6307b55) is acceptable; it is the mechanically required pin for this PR's src/scripts edit and I verified it matches git rev-parse 50f23bc:src/scripts.

The change is correct as far as I can verify; it touches the governance verifier, so a maintainer should sign off on the pin bump rather than me.

Trust-surface facts (.github/scripts/integration-governance.cjs:12): TRUSTED_SCRIPTS_TREE moves from 1e72143f… to 6307b555…. 1e72143f… is origin/v5:src/scripts; 6307b555… is 50f23bc:src/scripts — i.e. the new literal is exactly the tree produced by this PR's nine-line edit to src/scripts/comment-merged-refs.sh, which the verifier's own error text (:103) requires. No other line of the verifier changes. Author is the hive App bot (role/trusted).

What I verified on 50f23bc:

  • The section key the skip looks for, <!-- hive:status:section=issue-partial:<pr>, is what the runtime emits: src/pkg/prstatus/prstatus.go:27 (sectionOpenPrefix) and src/pkg/prstatus/issue.go:23,40 (KeyIssuePartialPrefix + pr).
  • src/scripts/comment-merged-refs.sh:180-187: the helper is invoked with the existing GH_BIN (:8) and only when executable; any helper failure (set -euo pipefail in the helper, 2>/dev/null at the call site) evaluates as "not present" and falls through to the pre-existing comment path — so the worst case is today's behaviour, never a dropped note.
  • .github/scripts/hive-status-card.sh:17-22 relies on gh api --paginate --slurp, which .github/scripts/pr-auto-update.sh already uses, so no new gh version floor.
  • The upsert subcommand is unused by this PR (it is for the workflow edits parked on #16363) — fine as shared groundwork, just noting it has no caller yet.

Body cites Part of #16363 (needs-human: …) and the checks on this head show cancelled/queued rather than red, so nothing in CI to triage.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026
hivecommons-hive Bot and others added 4 commits November 3, 2026 02:22
…flow change

The issue-closed-reopen-hint.yml edit cannot be pushed by the App token
and only exists as a diff on #16363, so the table now says the row is
pending rather than live.

Hive-Fix-Attempt: 1/6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…atus-card.sh

`has` used to test for `<!-- hive:status:section=<arg>` with no
terminator, so `issue-partial:163` matched a card that only carried
`issue-partial:1638` and the refs sweep silently skipped its one-per-issue
nudge for the wrong PR. Parse the rendered keys
(`<!-- hive:status:section=KEY -->`) and require an exact match; an
argument ending in `:` keeps prefix semantics (`issue-partial:`).

Add positive and negative test cases to test-comment-merged-refs.sh and
re-pin TRUSTED_SCRIPTS_TREE for the src/scripts change.

Hive-Fix-Attempt: 2/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…fetched comments

- `has` only trusts a hive:status card authored by a Bot account, so a human
  quoting the card's markers cannot suppress the refs-sweep nudge.
- `upsert` only edits a comment by HIVE_COMMENT_AUTHOR (default
  github-actions[bot]), never a third party's comment containing the marker.
- comment-merged-refs.sh passes its already-fetched comments via
  HIVE_COMMENTS_FILE, removing the second paginated GET per candidate issue.
- Tests cover the shared fetch, a human-quoted card, and upsert PATCH/POST
  with the author filter and HIVE_COMMENT_AUTHOR override.
- Narrow the changelog fragment to the refs-sweep behaviour this PR ships;
  document the author filters and HIVE_COMMENTS_FILE in notifications.md.
- Re-pin TRUSTED_SCRIPTS_TREE for the src/scripts change.

Hive-Fix-Attempt: 3/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 3, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style review (read at head 8a0a84b; the queued head 5060a8c has been rebased since). Section-key format verified against src/pkg/prstatus/prstatus.go:27-29 / issue.go:23; TRUSTED_SCRIPTS_TREE matches HEAD:src/scripts; src/scripts/test-comment-merged-refs.sh passes locally (14 new assertions ok). No blocker — two advisory notes:

  1. Helper tests are not run by CI. The upsert / has coverage for .github/scripts/hive-status-card.sh lives in src/scripts/test-comment-merged-refs.sh:496-588, and no workflow invokes that file (only src/scripts/test-check-*, test-release-lines-guard.sh, test-check-dco-trailers.sh are wired). Sibling .github/scripts/* helpers keep a co-located test-*.sh run from .github/workflows/v2-ci.yml:211-227. Since the workflow edit must be landed by a maintainer anyway (#16363), consider folding a bash .github/scripts/test-hive-status-card.sh (or the existing sweep test) step into that same diff.

  2. Silent fail-open. src/scripts/comment-merged-refs.sh:184-195 skips the card check without any log line when the helper is missing/non-executable, and 2>/dev/null on the has call hides a python/JSON failure as "no card". Fail-open is the right default, but an echo "card check unavailable…" on the else path would make a mis-wired checkout visible in the run log. Minor: comments() in the helper (hive-status-card.sh:32-41) re-implements the --slurp page flattening the sweep already has as flatten_json_pages.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Needs a decision, not a merge:

  • the reviewer swarm returned requires_human @8a0a84b
  • the review found: the reviewer marked this change high-risk
  • reviewer question: @clubanderson should confirm the TRUSTED_SCRIPTS_TREE re-pin to 9ba1ee4cedf0c05df6d68b5ef905fed8a2924af5 in .github/scripts/integration-governance.cjs is acceptable to land with this PR.
  • the automerge lane will not merge this unattended

Head: verdict requires_human @8a0a84b, 68/69 checks green, 1 pending, DCO yes, soak 0s of 10m0s.

What to do: approve this head (8a0a84b) to merge as-is, or leave a changes requested review (or reply /hive decision <what to change>) and the hive will push the fix.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@clubanderson clubanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owner decision for reviewed head 8a0a84b: approve the intended helper and exact scripts-tree repin. Independently fetched this Git object: 8a0a84b:src/scripts resolves to 9ba1ee4cedf0c05df6d68b5ef905fed8a2924af5, exactly matching TRUSTED_SCRIPTS_TREE. The verifier still checks both prepared source closure and HEAD scripts tree; there is no wildcard or dynamic trust-anchor relaxation. The helper uses exact section matches, reuses fetched comments, and only edits the configured posting identity own comment. Bot-wide card recognition affects notification suppression only, not merge authority. Recheck/repin after any subsequent scripts-tree change. The workflow edits and wiring these helper tests into CI remain explicit follow-through under #16363; this approval does not grant new token permissions or claim that deferred workflow work is deployed.

@clubanderson

Copy link
Copy Markdown
Member

/hive decision approve Approve the helper and exact TRUSTED_SCRIPTS_TREE=9ba1ee4cedf0c05df6d68b5ef905fed8a2924af5 for reviewed head 8a0a84b. Verified against that Git object, not just the displayed literal. Recheck if the scripts tree changes; deferred workflow work remains under #16363. Preserve all normal gates.

/lgtm
/approve

@kubestellar-prow kubestellar-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 86fdbec3a82af90de40e008f44cd05f9a71898be

1 similar comment
@kubestellar-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 86fdbec3a82af90de40e008f44cd05f9a71898be

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Nov 3, 2026
@kubestellar-prow
kubestellar-prow Bot merged commit 9c62646 into v5 Nov 3, 2026
99 of 107 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16363 branch November 3, 2026 15:41
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant