Repository navigation
✨ Add Crux-owned durable event and work lanes - #16373
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Docs map: this PR adds page(s) under
A page missing from the map is one readers do not find. Please add a If the page is indexed from a subdirectory README, or is deliberately |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Style re-review at 509abf8 (delta vs b1041e5: 6 files under The delta is clean from a style perspective — The three style findings from the previous head are still present and unchanged:
for group, m := range l.Groups {
if !ValidID(group) || len(m) == 0 || len(m) > DefaultMaxMembers {
return fmt.Errorf("%w: delivery group", ErrInvalid)
}
- for group, m := range l.Recoverers {
- if !ValidID(group) || len(m) == 0 || len(m) > DefaultMaxMembers {
- return fmt.Errorf("%w: recovery capability", ErrInvalid)
- }
- for _, p := range m {
- if !allowed(l.Groups[group], p) {
- return fmt.Errorf("%w: recoverer must be a group member", ErrInvalid)
- }
- }
- }
members = append(members, m...)
}
+ for group, recoverers := range l.Recoverers {
+ if !ValidID(group) || len(recoverers) == 0 || len(recoverers) > DefaultMaxMembers {
+ return fmt.Errorf("%w: recovery capability", ErrInvalid)
+ }
+ for _, p := range recoverers {
+ if !allowed(l.Groups[group], p) {
+ return fmt.Errorf("%w: recoverer must be a group member", ErrInvalid)
+ }
+ }
+ }
Review findings from Read the trust boundaries and wiring at 24a9ffc, not the full 7.5k-line diff. What I verified looks correct; what I did not read is named below so a human can scope their own pass. Verified
Not read in depth: the Claim/recovery state machine in Info: Nothing blocking from the parts I read. Review findings from HUMAN DECISION NEEDED — @clubanderson: accept a new Crux subsystem (NATS JetStream broker + Delta re-review (3c77f34 → 24a9ffc): the only new commit is Prior findings at this head:
Advisory (not blocking, author's call): Review findings from docs-currency — delta re-review at 509abf8 (prior head b1041e5) The delta (
(Adjust Required/Default to match
Limits: GitHub API hourly cap was reached mid-review, so I re-read Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Review findings from Docs-currency review (head The new
Reference only (already raised by the docs-index reminder, not a new finding): Review findings from Routing this one to a second approver rather than judging it alone: it is a new subsystem ( What I verified
The decision: this is the first embedded message broker in the Hive binary, and I have not approved or requested changes as a review event. Evidence bundle `#1637324a9ffc` sha256:f1f3268680f119a35f68b5870662a3c2a2e4348b74992518c5d5de3880ee897c — download from the dashboard or `hivectl review evidence #16373`. |
There was a problem hiding this comment.
Style/maintainability review at head 0f13049 (read the diff plus src/crux/lanes/*.go, src/crux/serve/lanes.go, src/crux/cli/serve.go, and the merge-base src/crux/api/api.go / callback.go / cli.go for conventions).
1. Config.Validate: recoverer validation is nested inside the groups loop and shadows group/m (src/crux/lanes/config.go:183-197)
The for group, m := range l.Recoverers loop sits inside for group, m := range l.Groups, re-declaring both loop variables. Effects:
- Recoverer checks run once per delivery group (redundant O(G×R)).
- A lane with
recoverersbut an emptygroupsmap never validates its recoverers at all — bad group IDs, unknown projects, and non-member recoverers are silently accepted at load time (the"recoverer must be a group member"error is unreachable in that case).authorize("recover")happens to still deny at runtime, but the config-time invariant the comment promises is not enforced, and nothing in the added tests exercises Recoverers rejection.
for _, l := range c.Lanes {
...
members := append(slices.Clone(l.Publishers), l.Subscribers...)
for group, m := range l.Groups {
if !ValidID(group) || len(m) == 0 || len(m) > DefaultMaxMembers {
return fmt.Errorf("%w: delivery group", ErrInvalid)
}
- for group, m := range l.Recoverers {
- if !ValidID(group) || len(m) == 0 || len(m) > DefaultMaxMembers {
- return fmt.Errorf("%w: recovery capability", ErrInvalid)
- }
- for _, p := range m {
- if !allowed(l.Groups[group], p) {
- return fmt.Errorf("%w: recoverer must be a group member", ErrInvalid)
- }
- }
- }
members = append(members, m...)
}
+ for group, recoverers := range l.Recoverers {
+ if !ValidID(group) || len(recoverers) == 0 || len(recoverers) > DefaultMaxMembers {
+ return fmt.Errorf("%w: recovery capability", ErrInvalid)
+ }
+ for _, p := range recoverers {
+ if !allowed(l.Groups[group], p) {
+ return fmt.Errorf("%w: recoverer must be a group member", ErrInvalid)
+ }
+ }
+ }A small Validate test for "recoverer not in group" / "recoverers for unknown group" would lock this in.
2. Lane API error codes are string literals, not api.Code* constants (src/crux/serve/lanes.go:62,67,176-192)
crux/api/api.go:250-256 defines CodeUnauthorized, CodeConflict, etc. as exported constants that clients and tests match on; src/docs/crux-lanes.md:80,124 document lane_conflict/lane_cursor as part of the contract. Yet the lane handler emits "lane_invalid", "lane_forbidden", "lane_conflict", "lane_cursor", "lane_stale", "lane_capacity", "lane_unavailable", "lane_timeout", "lane_canceled" inline, so api.Client users have nothing to compare api.Error.Code against. Suggest adding to src/crux/api/lanes.go:
const (
CodeLaneInvalid = "lane_invalid"
CodeLaneForbidden = "lane_forbidden"
CodeLaneConflict = "lane_conflict"
CodeLaneCursor = "lane_cursor"
CodeLaneStale = "lane_stale"
CodeLaneCapacity = "lane_capacity"
CodeLaneUnavailable = "lane_unavailable"
CodeLaneTimeout = "lane_timeout"
CodeLaneCanceled = "lane_canceled"
)and referencing them from writeLaneError/readLaneJSON.
3. Env var names are inline literals (src/crux/cli/serve.go:36,74, src/cmd/hive/lanes.go:16,20,37)
The crux convention is a named *EnvVar constant reused in the flag help text (config.ServeTokenEnvVar, callback.SocketEnvVar on the adjacent lines of serve.go:32,36; cli.DefsEnvVar at cli/cli.go:65). "CRUX_LANES_CONFIG" appears twice as a literal (help string and os.Getenv), and the five HIVE_LANES_* names are literals in cmd/hive/lanes.go. E.g. in src/crux/lanes/config.go:
// ConfigEnvVar names the opt-in lane configuration file for `crux serve`.
const ConfigEnvVar = "CRUX_LANES_CONFIG"then "... (default $"+lanes.ConfigEnvVar+")" and os.Getenv(lanes.ConfigEnvVar).
Item 1 is the one I'd want fixed before merge; 2 and 3 are convention alignment.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
0f13049
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
CI triage (
Human-authored PR, so no pushes from the hive; leaving for the author. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Intent alignment (head b1041e5): the diff matches the title — every touched file is lane-related (workflows only add the lane test step, NOTICE is the regenerated dependency manifest, governor.go:383 is an additive observer, api/client.go:282 is a 204 no-body guard). Opt-in is real: src/cmd/hive/lanes.go:15-17 returns unless HIVE_LANES_ADDRESS is set. Verdict: approve, one advisory.
Advisory — the "ordinary HTTP participant" links the NATS client into the Hive binary. src/pkg/laneparticipant/participant.go:15 imports crux/lanes only for lanes.ValidID (lines 52, 64, 72). crux/lanes/broker.go:16-17 imports nats.go/jetstream, so the hive binary — which at merge-base links no NATS code (only _test.go files in src/cmd/hive import crux/serve/crux/cli) — now carries the broker client to run a regex. The PR body and docs/crux-lanes.md:356 frame Hive as a peer that "use[s] Crux HTTP credentials, not direct broker credentials"; the import graph should say the same. Concrete fix: move the ID rule into the stdlib-only crux/api and have lanes delegate, e.g.
--- a/src/crux/api/lanes.go
+++ b/src/crux/api/lanes.go
+// MaxLaneIDLength and ValidLaneID are the wire-level identifier rule shared by
+// the broker and participants; stdlib-only so clients need not import crux/lanes.
+const MaxLaneIDLength = 64
+
+var laneIDPattern = regexp.MustCompile(`^[a-z][a-z0-9_-]*$`)
+
+func ValidLaneID(id string) bool { return len(id) <= MaxLaneIDLength && laneIDPattern.MatchString(id) }
--- a/src/crux/lanes/config.go
+++ b/src/crux/lanes/config.go
-func ValidID(id string) bool { return len(id) <= MaxIDLength && idPattern.MatchString(id) }
+func ValidID(id string) bool { return api.ValidLaneID(id) }
--- a/src/pkg/laneparticipant/participant.go
+++ b/src/pkg/laneparticipant/participant.go
- "github.com/hivecommons/hive/crux/lanes"
...
- if client == nil || !lanes.ValidID(lane) || !lanes.ValidID(group) {
+ if client == nil || !api.ValidLaneID(lane) || !api.ValidLaneID(group) {(and the two other lanes.ValidID call sites). Not blocking; fine as a follow-up.
— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Style / maintainability review (head c93b25b)
1. Config.Validate nests the Recoverers loop inside the Groups loop and shadows its variables — src/crux/lanes/config.go:181-195. The inner for group, m := range l.Recoverers (line 185) re-declares group/m from the outer for group, m := range l.Groups (line 181), so recoverers are re-validated once per group and members = append(members, m...) on line 195 runs after the shadow has gone out of scope only by accident of block scoping. A lane with recoverers but no groups is never validated at all (the outer loop body never runs). It reads like an indentation slip and will be fragile to edit. Hoist it to a sibling loop:
for group, m := range l.Groups {
if !ValidID(group) || len(m) == 0 || len(m) > DefaultMaxMembers {
return fmt.Errorf("%w: delivery group", ErrInvalid)
}
- for group, m := range l.Recoverers {
- if !ValidID(group) || len(m) == 0 || len(m) > DefaultMaxMembers {
- return fmt.Errorf("%w: recovery capability", ErrInvalid)
- }
- for _, p := range m {
- if !allowed(l.Groups[group], p) {
- return fmt.Errorf("%w: recoverer must be a group member", ErrInvalid)
- }
- }
- }
members = append(members, m...)
}
+ for group, recoverers := range l.Recoverers {
+ if !ValidID(group) || len(recoverers) == 0 || len(recoverers) > DefaultMaxMembers {
+ return fmt.Errorf("%w: recovery capability", ErrInvalid)
+ }
+ for _, p := range recoverers {
+ if !allowed(l.Groups[group], p) {
+ return fmt.Errorf("%w: recoverer must be a group member", ErrInvalid)
+ }
+ }
+ }2. Lane error codes are inline string literals, not api.Code* constants — src/crux/serve/lanes.go:68,73,185-204. The existing wire contract publishes codes as constants (src/crux/api/api.go:248-256, CodeUnauthorized, CodeConflict, …) so clients and tests match on symbols; the nine new lane_* codes exist only as literals in the server and prose in src/docs/crux-lanes.md. Add CodeLaneInvalid, CodeLaneForbidden, … to crux/api next to the others and use them in writeLaneError/readLaneJSON.
3. Broker init failure hides the cause — src/crux/cli/serve.go:98 prints crux: lanes: cannot initialize durable broker and drops err, unlike every other failure path in the same function (crux: serve:, crux: all print err). lanes.Open already returns typed errors (ErrConflict: stream configuration differs, ErrUnavailable, …) that carry no credentials (Config.Validate rejects inline URL creds), so an operator with a mis-sized stream has no way to tell that from a dead broker. Same pattern in src/cmd/hive/lanes.go:23-40, where four distinct logger.Error branches omit the err value.
fmt.Fprintln(e.Stderr, "crux: lanes:", err)
4. Test writes a fixture into the package source dir — src/crux/lanes/auth_test.go:48 creates .lane-config-<nanos>.json in the cwd (the package directory) and relies on t.Cleanup to remove it; a killed run leaves it in the tree. The crux tree uses t.TempDir() (~30 call sites); use filepath.Join(t.TempDir(), "lanes.json") here.
Advisory: Validate collapses ~25 bound checks into one lane configuration bounds error (config.go:152-160), and the JSON config takes durations as integer nanoseconds (config.go:76-83, documented at crux-lanes.md "Bounds and failure behavior"). Both are defensible but will cost operators time; consider per-field messages and string durations in a follow-up.
— hive: agent=adjudicator-5 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Current-head native review handoff — not an approvalCurrent head is Actual checks on this head passed: canonical build/integration (including the overlay guard), all 23 test shards, coverage/patch coverage, lint, govulncheck, gosec and NOTICE. Lanes measured 91.4% against the unchanged 90% floor. The real near-byte-cap test passed in 88.76s; the newly added empty-Groups/Recoverers, defaults, duplicate/whitespace and project/lane/group authorization regressions also ran and passed. Evidence: build workflow, test workflow, actual lane test execution, security/NOTICE. The latest posted style review 5747443022 is API-bound to 8ccb, but its body explicitly reviews c93 and proposes the nested-Recoverers fix already delivered in 8ccb. The env inventory and documentation index omissions are also corrected. This does not make that review a current-head clearance. Its still-applicable error-code/diagnostics/fixture observations should be assessed against current source, not silently discarded; in particular, blindly logging rejected address errors can expose input and needs careful treatment. Following the existing author-reply/ordinary review path: please review 98fa96f and collect genuine current-head reports for the configured native perspectives. No synthetic verdict, dismissal, label/permission change, bypass or CI rerun is requested. Native approval/admission remains separate from the passing technical checks and source-review clearance. |
There was a problem hiding this comment.
Style re-review at 98fa96f (delta since c93b25b = v5 forward-merge + 8ccbda8d).
Fixed: the Recoverers loop nested inside the Groups loop with shadowed group/m (src/crux/lanes/config.go:181-196 is now two sibling loops, covered by config_recoverers_test.go). The forward-merge itself is a clean first-parent replay of v5 — no conflict-resolution drift.
Still present (new code this PR adds; each has a drop-in fix):
src/crux/cli/serve.go:98— broker init failure discardserr, so an operator debugging a badCRUX_LANES_CONFIG/NATS URL sees only a generic line.
fmt.Fprintf(e.Stderr, "crux: lanes: cannot initialize durable broker: %v\n", err)
src/crux/serve/lanes.go:185-200— lane error codes are inline string literals, while the rest of the API surface names them insrc/crux/api/api.go:250-256(CodeUnauthorized,CodeBadRequest, …). Clients (api/lanes_client.go) have nothing to match against. Add alongside the existing block:
CodeConflict = "conflict"
CodeRuntime = "runtime_error"
+
+ CodeLaneUnavailable = "lane_unavailable"
+ CodeLaneForbidden = "lane_forbidden"
+ CodeLaneInvalid = "lane_invalid"
+ CodeLaneConflict = "lane_conflict"
+ CodeLaneCursor = "lane_cursor"
+ CodeLaneStale = "lane_stale"
+ CodeLaneCapacity = "lane_capacity"
+ CodeLaneTimeout = "lane_timeout"and reference them in writeLaneError.
src/crux/lanes/auth_test.go:48—TestLoadConfigStrictAndBoundedwrites.lane-config-<nano>.jsoninto the package source directory and relies on a manualos.Removecleanup; a failed run leaves stray files insrc/crux/lanes/.
path := filepath.Join(t.TempDir(), "lane-config.json")
(drop the t.Cleanup/os.Remove block.)
src/crux/lanes/config.go:151-160— one 9-line predicate collapses ~25 independent bounds into a singlelane configuration boundserror; an operator cannot tell which field failed. Splitting into per-field checks (or a smallcheck(cond bool, what string)helper) would make the error actionable. Advisory.
— hive: agent=adjudicator-5 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Current-head native review handoff — not an approvalCurrent head is This publishes the surgical corrections to the genuine
Canonical current-head build, all test shards/coverage, and lint/security/module NOTICE were still running at the initial observation. Prior Please use the existing ordinary native review/collection path for genuine head-specific reports across the configured perspectives. This factual handoff is not an approval or review receipt and does not request dismissal, bypass, labels/permission changes, synthetic verdicts or CI reruns. Preserve any still-applicable findings and identify their reviewed head. |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Current-head review handoff and named dependency decision request — not an approvalCurrent head is
The prior surgical source corrections (sanitized typed diagnostics, all nine stable wire constants, bounded strict parser/committed fixtures) are preserved. Normal current-head build/integration, tests/coverage and lint/security/module NOTICE were running at the initial observation; the current docs link check passed. Prior Existing named dependency decision: the folded native Please use the existing ordinary collection path for genuine current-head correctness, security, intent-alignment, style and docs-currency reports plus the actual approval perspective. This factual author handoff supplies no review receipt, approval, dismissal or bypass, and requests no permission/label changes, synthetic verdicts or CI reruns. |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether a 7.5k-line, 60-file lane subsystem with no linked issue or spec should land as one PR on v5, or be split (API/auth/serve wiring first, broker/work-recovery core second) so the broker core gets a human read before it ships.
Routing to a human; not a defect report. This PR is too large for me to verify end-to-end, so I read the parts a maintainer would most want checked and I am explicit below about what I did not read.
Verified (read the code at 3c77f34):
- Workflows (
.github/workflows/v2-ci.yml:200-207,integration-candidate.yml:258-261,integration-technical-v2-ci.yml:124-127): each adds onego test -racestep forcrux/{lanes,api,serve}andpkg/laneparticipant. Nopermissions:changes, no new secrets, no removed checks. - Auth boundary (
src/crux/lanes/auth.go,src/crux/serve/lanes.golaneHandler,serve.goauthenticate): project tokens are resolved only from admin-chosen env vars, rejected if <32 bytes, whitespace-containing, equal to the agent-control token, or duplicated (auth.go:22-30);Project()is constant-time and nil-safe (auth.go:36-46). The lane mux rejects anything that is not a project token (lanes.golaneHandler), andauthenticatenow rejects project tokens on agent RPCs before the legacy token/unix checks — so the two credential domains cannot cross in either direction. Request bodies are bounded byhttp.MaxBytesReaderandDisallowUnknownFields(readLaneJSON). This part looks correct to me. - Dependencies / NOTICE:
nats-server/v2is imported only from_test.gofiles (lanes/broker_test.go,lanes/work_slots_test.go,serve/lanes_test.go,pkg/laneparticipant/participant_test.go); production binaries only pick up thenats.goclient and connect toConfig.URL. The NOTICE hunk looks like it deletesledongthuc/pdf,go-colorful,go-isatty— it does not; all three are still present at head, the diff is alphabetical reflow around the newklauspost/compressentry.check-notice-driftis green.
Not read: lanes/broker.go (387 lines), work.go, work_recovery.go, work_budget*.go, and their ~2.5k lines of tests — the lease/revision-fencing/retry-rotation core. I have no finding against them; I simply cannot confirm them within a review budget, and nothing else (no linked issue, spec, or prior design PR) does either. The body's own validation section says executable Go validation is "pending canonical CI" — CI is now green on this head, which is the only independent signal so far.
Two small things, neither blocking:
src/go.mod:github.com/nats-io/nats-server/v2 v2.15.2sits inside an// indirectblock without the marker;go mod tidywould relocate it. Cosmetic.- No
Closes #N/Refs #N. If there is a tracking issue for Crux lanes, linking it would give the next reviewer the intent to judge against.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict requires_human @3c77f34, 70/70 checks green, DCO yes, soak 10m0s elapsed. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm this 7.5k-line, issue-less feature is meant to land on v5 as one PR with nats-server/v2 (plus go-tpm, antithesis-sdk, x/crypto, x/time) added to both src/go.mod and src/crux/go.mod, rather than crux-first behind the opt-in.
No defects found in the parts I read at 24a9ffc; routing for a scope decision, not a code problem.
Verified (tree + callers):
- Auth domains are genuinely separate.
src/crux/serve/serve.go:158wraps the legacy handler ass.laneHandler(s.authenticate(mux)), so/lanes/**never reaches the admin-token path, andserve.go:173-176rejects any project token that tries an agent RPC.src/crux/lanes/auth.go:19-33refuses a project token equal to the serve token, shorter than 32 bytes, or duplicated across principals;Project()compares in constant time and does not short-circuit.authorize()atsrc/crux/lanes/config.go:245-263is the single capability gate every broker verb goes through. serve/lanes.go:62-77bounds bodies withMaxBytesReaderatbase64(MaxPayload)+8KiB, usesDisallowUnknownFields, and rejects trailing JSON;writeLaneError(serve/lanes.go:181-206) maps typed errors only and never leaks broker addresses.cli/serve.go:122-134does the same for startup failures.AddModeChangeObserver(src/pkg/governor/governor.go:383-397) chains rather than replaces, so the existing local observer keeps firing.- The three workflow edits (
v2-ci.yml:200-207,integration-candidate.yml:258-261,integration-technical-v2-ci.yml:124-127) only add ago test -racestep for the new packages; nopermissions:or trigger change. nats-server/v2is imported bysrc/crux/lanesand bysrc/pkg/laneparticipant/participant_test.goonly — the hive binary itself does not link the embedded server; the non-indirect line insrc/go.mod:63is from the test import.
Why a person: the PR carries no Closes/Refs issue, is size/XXL, and is the first time the NATS server stack enters the module graph of both modules. The body says opt-in only (and the code agrees — cli/serve.go:74-103 does nothing without -lanes-config/CRUX_LANES_CONFIG), but whether the dependency footprint and single-PR landing on v5 is the intended shape is an owner call I should not make. I have not read all 60 files; the broker's JetStream state machine (lanes/broker.go, work.go, work_recovery.go) I only spot-checked, and I am relying on the race-enabled suite (green in test (agent|rest) and contract-tests) for that.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 24a9ffc. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
Adds forge-neutral Crux-owned event/work lanes backed by NATS JetStream, with Hive as an opt-in peer participant. Work uses independent consumer groups, revision-fenced leases, replay, explicit expiration recovery, fair retries, and bounded durable acknowledgement history.
Includes namespace isolation, duplicate-publish identity verification, authorized foreign-expiration recovery, persisted retry rotation, and physical completion/recovery reservations with reusable nonshrinking slots.
Validation
Independent precommit review cleared staged diff SHA-256
31b7856138377b09c621cd46270ffc29a83f5b73cf29dc5b6361c703c365c2ea. Embedded-broker and API/serve/config regressions cover restart, lost responses, stale receipts, retry starvation, expiration recovery, and near-byte-capacity operation. Formatting and whitespace checks passed. Executable Go validation is pending canonical CI, as required by repository policy; no passing build/test claim is made yet.Rollout
Opt-in only. No live NATS deployment or production enrollment is enabled by this publication.