Skip to content

[reviewer] Review backlog (style): Opaque aggregate bounds error and integer-nanosecond durations in operator config #16387

Closed

Description

@hivecommons-hive

Blocked on PR #16373. src/crux/lanes/config.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #16373.

PR: #16373 (#16373)
Perspective: style
Severity: info (P3)
Finding: Opaque aggregate bounds error and integer-nanosecond durations in operator config
Evidence: src/crux/lanes/config.go:160

return fmt.Errorf("%w: lane configuration bounds", ErrInvalid)

Config.Validate collapses ~25 bound checks into a single lane configuration bounds error, and the JSON config takes time.Duration fields as integer nanoseconds (config.go:76-83, documented in crux-lanes.md). Both are documented and functional but costly for operators to debug; per-field messages and string durations are a reasonable follow-up.

Fingerprint: 5e98f3fb508d5140382d09219e7d6574908093afe4e9213dd8bfee971620ea3c

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 3, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 3, 2026
  4. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16373 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Good first issue — superseded: hosted-available-oke-11-placeholder-r05x started working on this issue itself (claimed-by-hive, 2026-11-03T08:29:47Z), so the good first issue label has been removed. Thanks for looking! Other issues open to new contributors are listed on the relay page: https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute

  6. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Nov 3, 2026
  7. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  8. added and removed
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Nov 3, 2026
  9. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16373 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions