Repository navigation
π fix: durably apply decisions before optional reporting - #16299
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Independent bounded source review completed against 7d08679: no remaining high-confidence correctness/compile/liveness findings after fixing both discovered issues (hung HTTP fixture cleanup; failed singleton native-record ghost replay), with regressions. This is source review, not GitHub approval or merge authority. The first CI failure was a shifted RankActionableIssues citation in scale-envelope.md. Per AGENTS.md I first ran the prescribed --fix command only after that CI failure; it reported UNRESOLVED for the inline AgeMinutes anchor. This follow-up narrowly reanchors the cited range to the actual declaration/body. No local Go tests/build/lint/guards were run. CI remains the executable verdict; normal independent maintainer review remains requested. |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Intent alignment (read at head 2a2b8da): the core contract β record the validated native approval before optional reporting, bound reporting, surface
Advisory: the Review findings from Correctness review at head 2a2b8da (read the diff plus 1. Post-effect acknowledgment is now cancellable β a successful external call can be left Suggested fix ( β¦and the same 2. Spurious Out of scope but noted: Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
|
Owner-directed completion receipt for exact head |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Concurrent author update preserved: the branch advanced to |
|
Current-head CI now reports genuine failures on |
|
Completed dashboard-shard log inspection on exact head |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
HUMAN DECISION NEEDED β @clubanderson: should a delegated ("Let hive decide") AI approve on a contributor's PR persist a human-attributed native approval that releases requires_human in the contributor lane? This PR makes that true; the body/changelog say merge gates are not weakened.
Security perspective, read at head 2a2b8da.
1. Delegated AI verdict now clears the requires_human gate on third-party PRs (trust-boundary widening, in-scope).
src/pkg/dashboard/api_repo_item_decide_delegated.go:915-926 β for every KindPR with mergerRole and VerdictApprove, the delegated path now calls RecordOperatorPullRequestApprovalWith(... HumanChangeRequests: repoItemDecisionChangeRequests(), LiftNeedsHuman: true ...) before anything else. At merge-base that record was written only in the self-authored !queued.ReviewSubmitted branch (removed hunk, old lines 924-941); contributor PRs got an App APPROVE review + queue label only.
The record lands as Kind: approve, Actor: <operator> (src/pkg/github/pr_decision_operator.go:393-401), and the contributor lane reads exactly that as the trusted human's answer: automerge_review_gate.go:324-355 (recordedHumanApprovalForHead β IsApproval() β "releases requires_human the way an APPROVED review on the head does"). The App's own review is not a trusted-human approval (latestTrustedHumanApproval, :314-322), so previously a requires_human contributor PR stayed parked after a delegated approve; now the model's verdict, stamped with the operator's login, releases it without the operator having read the PR. The diff also deletes the comment that documented the old invariant (pr_decision_operator.go hunk: "which is what the delegated 'Let hive decide' path keeps: a recommendation must not clear a person's gate").
If this is intended, state it in the PR body and changelog (which currently say "without weakening merge gates"). If not, gate the new block on in.SelfAuthored/hive-authored only, e.g.:
if in.Kind == delegatedecision.KindPR && mergerRole && d.Verdict == delegatedecision.VerdictApprove && !d.KeepsPark && !in.SentinelAlert && in.HiveAuthored {
(or pass HumanChangeRequests: nil for contributor PRs so only the GitHub review/queue path runs, as before).
2. Hold guard ignores configured extra hold labels (low, in-scope).
src/pkg/github/pr_decision_operator.go:375 checks labelPresent(labels, "hold") literally, while the rest of the client uses c.isHeld(labels) which also honours c.holdLabels (client.go:3747-3755). A repo whose hold label is configured differently is not protected by the new rail.
if c.isHeld(labels) || opts.GuardSentinelLabel != "" && labelPresent(labels, opts.GuardSentinelLabel) {
The actor-write revalidation (:374-389), exact head/body-digest/author binding (:370-373), QueuePRAutoMergeWithNoteResultAtHead head check (client.go:3160-3162), and the failed-persist rollback in human_change_request.go:235-250 are sound and tighten the path. Not verified: delegated-path test coverage of a contributor PR carrying a requires_human verdict.
β hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
Validation
Boundaries
This is source-only: no queue clearing, live decisions, labels/signoffs, reruns, controller restart or production rollout. Existing merge/review/CI authority requirements remain. Ordered journal writes still serialize and rewrite the snapshot; context bounds admission/network waits, not physical filesystem/fsync latency. No deployed throughput improvement is claimed.
Requesting normal independent maintainer review; this PR does not authorize or impersonate its own approval.