Repository navigation
π fix(governor): bound historical terminal PR accounting - #16289
Merged
Merged
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Nov 2, 2026
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence and limits
Measured main-goroutine samples showed FetchClaimScan waiting in terminal ListReviews and timeline atomic persistence before current-work planning/sweeps. This fixes that synchronous accounting dependency, not every backlog gate or all filesystem latency. No universal end-to-end speedup is claimed. Uninterruptible hooks/fsync can still occupy the accounting worker; new precious writers retain durability barriers. Pending accounting remains in memory and restarts/client rebuilds replay the existing 72-hour settle window; no new recovery-window claim.
Related work
Complements the measured throughput follow-through; does not duplicate review collection #16280, triage cache #16281, or reservation identity work. No live queue clearing, reruns, kicks, forced claims, approval bypass, capacity/budget/trust changes, or rollout.
Testing
Contributor checklist
Deployment is separate: source publication is not a production fix.