Skip to content

πŸ› fix(governor): bound historical terminal PR accounting - #16289

Merged
clubanderson merged 1 commit into
v5from
ci/execution-critical-path-20261102
Nov 2, 2026
Merged

clubanderson merged 1 commit into
v5from
ci/execution-critical-path-20261102

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

  • Keep authoritative open/closed listings, claim extraction, churn history, ledger persistence, and fail-closed dispatch filtering synchronous.
  • Move historical merge-actor enrichment, terminal accounting sinks, and terminal review reads into one cancellable client worker: at most eight attempts per batch, ten-second API budget, existing exponential retry backoff, semantic coalescing, and in-flight revision fencing.
  • Retire replaced-client workers. Preserve original historical timestamps and recent-history restart replay; do not treat deferred accounting as ownership authority.
  • Avoid unchanged historical timeline count/file churn. Persist first sightings and corrected precious metadata; retry dirty saves. Serialize atomic disk writers without holding the journey reader mutex, preserving concurrent unsaved state.

Evidence and limits

Measured main-goroutine samples showed FetchClaimScan waiting in terminal ListReviews and timeline atomic persistence before current-work planning/sweeps. This fixes that synchronous accounting dependency, not every backlog gate or all filesystem latency. No universal end-to-end speedup is claimed. Uninterruptible hooks/fsync can still occupy the accounting worker; new precious writers retain durability barriers. Pending accounting remains in memory and restarts/client rebuilds replay the existing 72-hour settle window; no new recovery-window claim.

Related work

Complements the measured throughput follow-through; does not duplicate review collection #16280, triage cache #16281, or reservation identity work. No live queue clearing, reruns, kicks, forced claims, approval bypass, capacity/budget/trust changes, or rollout.

Testing

  • Not run locally: AGENTS.md requires CI as executable verdict; only gofmt and whitespace inspection performed.
  • Targeted regressions added for blocked review/accounting versus current claims, failed listings preserving claims, bounded batch/deadline/backoff/cancellation, in-flight corrected and identical replay, restart replay, client retirement, timeline precious durability/idempotency/retry, and concurrent dirty-snapshot/read servicing.
  • Independent bounded read-only review by existing reservation owner; identical-replay liveness finding fixed with semantic coalescing and regression. No new implementation agents.
  • Exact-head CI verdict pending.

Contributor checklist

  • Single-bullet changelog fragment and directly related audit documentation.
  • Targets v5; emoji title; DCO-signed normal commit/push.
  • No credentials or runtime state committed.
  • Normal OWNERS/Prow approval and required checks; no self-approval or bypass.

Deployment is separate: source publication is not a production fix.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson requested a review from hanthor November 2, 2026 18:58
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 2, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16299 πŸ› fix: durably apply decisions before optional reporting same files src/pkg/github/client.go
#16291 ✨ feature: persist single-admitter condition episodes same files src/cmd/hive/github_client_config.go
src/pkg/github/client.go

@clubanderson
clubanderson merged commit 64b32eb into v5 Nov 2, 2026
82 of 86 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the ci/execution-critical-path-20261102 branch November 2, 2026 20:33
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant