Repository navigation
π fix: advisory checklists resolve themselves and never park on a person - #15765
hivecommons-hive[bot] wants to merge 2 commits into
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #15765 is closed in favour of #15767, which carries the same advisory-autoclose change plus the delegated-plan would: close half this PR defers.
This appears to duplicate #15767, which makes the same change for #15754 β and the two cannot both merge.
What I verified by reading both diffs against their merge-bases:
- Same semantic change: both add
dedupe.advisory_autoclose(*bool, unset = on) topkg/config, the samesettings_parity_allowlist.txtline, the same sweep inpkg/githubthat ticks- [ ] #Nβ- [x]and closes as completed with "All N items resolved (β¦) β closing this advisory.", and the same tracker caption "Advisory Β· hive is working the items (k/N resolved)". - They conflict, not coexist: this PR names the type
config.DedupeConfigwith optionCloseOnMergeOptions.DisableAdvisoryAutoclose; #15767 names themDedupeLaneConfig/AdvisoryAutocloseOff, and both editconfig.go,close_on_merge.go,close_on_merge_sweep.go,dedupe_checklist_findings.go,stage_tracker_advisory.go. - The name here is also why
test (dashboard 1/4)is red.src/pkg/config/dedupe.go:5declarestype DedupeConfig, andsrc/pkg/writeback/config.go:84already declares a differentDedupeConfig(burst_items,hourly_cap, β¦).settingsparity.resolve(src/internal/settingsparity/settingsparity.go:188-190) resolves a bare identifier through a globalbyNamemap, soConfig.Deduperesolves to the writeback struct andTestSettingsDialogReferencesEveryHiveYAMLLeaffails withdedupe.burst_items,dedupe.burst_window,dedupe.enabled,dedupe.hourly_capnot allowlisted. #15767 avoids this by naming the typeDedupeLaneConfig. - Scope: this PR's body leaves the advisory half of item 3 (
would: close/ "Keep open; hive is working k/N items") to a sub-issue; #15767 implements it (pkg/delegatedecision/policy.go,api_repo_item_decide_delegated.go) andCloses #15754.
Recommendation: #15767 is the one to keep β broader, closes the issue, and does not trip the parity resolver. I have not closed anything; flagging for a maintainer.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #15765 is closed in favour of #15767, which implements the same two #15754 fixes (same dedupe.advisory_autoclose knob, same tick-and-close sweep, same issue-plan wording) plus the advisory would: close half this PR defers.
This appears to duplicate #15767, which makes the same change for #15754 and is the broader of the two.
What I verified by reading both diffs against v5:
- Both add
dedupe.advisory_autoclose(src/pkg/config/dedupe.go,config.go,settings_parity_allowlist.txt,agent_runtime_golden.json), both wire it throughcloseOnMergeOptionsForinsrc/cmd/hive/close_on_merge_sweep.go, both tick- [ ] #Nβ- [x]and close ascompletedwith an "All N items resolved (β¦)" comment, both drop the 045 park fromstage_tracker_advisory.go, both reword the issue delegated plan. Same semantics, same intent, 9 overlapping files edited independently β so they conflict, they cannot both merge. - #15767 also covers the half this PR's body explicitly leaves to a sub-issue (advisory
would: closeindelegatedecision/policy.go+ executor), so it is the superset.
This PR's CI is red and both failures come from its own diff (run 41061173342):
settings_parity_test.go:33βdedupe.burst_items,dedupe.burst_window,dedupe.enabled,dedupe.hourly_cap,dedupe.same_item_ttlreported as unallowlisted. The newconfig.DedupeConfig(src/pkg/config/dedupe.go) shares its bare name withwriteback.DedupeConfig, so the parity resolver picks up the writeback struct's fields underdedupe.*. #15767 sidesteps this by naming the typeDedupeLaneConfig.indexgen_test.go:28βstatic/index.htmldiffers from the concatenation ofstatic-src/at line 19713. This PR editssrc/pkg/dashboard/static/index.htmldirectly without the matchingstatic-src/js/*change; #15767 editsstatic-src/js/tracker-*.jsand regenerates.
Flagging for a maintainer: if you agree, this one could be closed in favour of #15767. I have not closed anything.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
settingsparity resolves bare identifiers by name across every collected package, so config.DedupeConfig resolved to writeback.DedupeConfig and TestSettingsDialogReferencesEveryHiveYAMLLeaf reported the writeback dedupe leaves as unallowlisted. Rename to DedupeAdvisoryConfig. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
CI triage β The job failed in A layer referenced by the imported GHA buildx cache manifest ( π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Superseded by #15767 (covers all of #15754 including the advisory plan wording β |
Refs #15754 β items 1, 2, 4 and the issue half of item 3 are fixed here; the advisory half of item 3 (delegated plan
would: close/ "Keep open; hive is working k/N items") is left to a sub-issue of #15754 because the plan's button runsdecide-delegated, and an honest "close" needs a new delegated verdict/action indelegatedecision/policy.go+ the executor, both under edit in #15741 and #15757.Why
#15734 (a dedupe checklist parked at 045, "Decision required: yes") asked a person to click when the hive had already closed or merged most of its items. The only auto-close path handled
triage/advisory-labelled checklists, so a parked checklist could not close itself. Also, "Let hive decide" on an issue described a PR approval: "Approve #15734 as it is and let the merge queue merge it."What changes
src/pkg/github/dedupe_advisory_items.go). The close-on-merge backfill now runs an item pass on every hive-authored dedupe checklist, labelled or not, including one parked at 045. It ticks each- [ ] #N β¦(alsoPR #N,owner/repo#N) to- [x]once #N is closed or merged. When every task-list line is resolved, it posts one comment, "All N items resolved (#a closed, #b merged β¦) β closing this advisory.", and closes the checklist as completed. A line that doesn't start with a reference waits for a person to tick it. A checklist someone reopened after the hive closed it is left alone (same marker as before). Writes go throughWritebackAllowed(issue_close). The existing close tail moved intocloseDedupeAdvisoryand is reused, so the writeback ratchet counts don't change. For atriage/advisorychecklist whose items are still open, the existing refs/expiry/reclassify rules still run.stage_tracker_advisory*.go). An advisory row drops the 045 stage, the needs-decision pill and thedecision_needed/blockerblocks. A checklist with task lines reads "Advisory Β· hive is working the items (k/N resolved)", with the hive as actor and the optional lead "Close now" (the existingclose-read). k/N comes from the body, which the enumeration already carries asIssueAdvisory.items/resolved, so this adds no API calls.api_repo_item_decide_delegated_plan_issue.go, one-line hook). An approve on an issue now reads "Approve the direction of #N and let the hive pick it up." with issue consequences. PR wording is unchanged.dedupe.advisory_autoclose(newDedupeConfig,*bool, unset = on). It's additive, andfalseturns the item pass off. It is wired throughcloseOnMergeOptionsFor, allowlisted as yaml-only, and added to the golden as"dedupe": {}.Edits to files shared with #15741/#15757 are minimal and additive: one hook line in the plan file and one field in
config.go, away from their hunks.Tests
dedupe_advisory_items_test.go: closes once all items resolve (closed vs merged wording), ticks and waits, items without a leading reference, knob off, a foreign author, a labelled advisory falling through to the old rules, progress/ref parsing.stage_tracker_advisory_working_test.go: wording, knob, never-parks (045, decision, blocker, needs-human, waiting), and a built triage: duplicate and overlapping open issues/PRs to consolidateΒ #15734 row.api_repo_item_decide_delegated_plan_issue_test.go: issue vs PR wording.config/dedupe_test.go,cmd/hive/close_on_merge_advisory_autoclose_test.go: knob default and wiring.Docs: operator-reference (new
dedupesection), labels reference (triage/advisory), activity-monitor (advisory row). Changelog:changelog.d/fixed-15754-advisory-checklists-autoclose.md.Filed by the hive scanner for #15754 (reported by @clubanderson).
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson