Repository navigation
π stage tracker: record the soak deadline once instead of re-stamping the note every pass - #15760
Merged
Merged
Conversation
β¦ the note every pass The contributor lane reported contributor-lane:soaking(remaining=12m0s), a reason that changed every pass; ObserveProgress restamped Reason and LastSeen, dirtying and saving the store each pass, and the dashboard aged the caption from LastSeen while the SPA treated each countdown text change as a new Hive: line. The owner saw the note refresh every minute of a soak. Record the soak head/start/window once on the stage record and report the stable contributor-lane:soaking reason. LastSeen no longer counts as a record change (persisted at most every 10m). The record carries ReasonChangedAt; the dashboard sends note_changed_at and computes the time left from the recorded deadline at request time (soak complete at/after the deadline, never 0s left). The SPA refreshes the countdown in place for the same note. soakRemainingFromReason stays as a legacy parser. Closes #15758 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Oct 30, 2026
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15758
Owner report: "we do not need the hive comment to refresh every minute of a soak."
contributor-lane:soaking(relay refusal still says "N remaining").stagelabels:LastSeenno longer counts as a record change and is persisted at most every 10m; records carryReasonChangedAt; unchanged passes leave the store clean.note_changed_at; the SPA refreshes the countdown in place instead of opening a new "Hive:" line.soakRemainingFromReasonkept as a legacy parser for pre-change records.