Skip to content

πŸ› stage tracker: record the soak deadline once instead of re-stamping the note every pass - #15760

Merged
clubanderson merged 1 commit into
v5from
fix/soak-caption-no-restamp
Oct 30, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/soak-caption-no-restamp

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Closes #15758

Owner report: "we do not need the hive comment to refresh every minute of a soak."

  • Contributor lane records the soak head/start/window once on the stage record; reason is the stable contributor-lane:soaking (relay refusal still says "N remaining").
  • stagelabels: LastSeen no longer counts as a record change and is persisted at most every 10m; records carry ReasonChangedAt; unchanged passes leave the store clean.
  • Dashboard: "N left" computed from the recorded deadline at request time ("soak complete β€” merges on the next pass" at/after it), explicit note_changed_at; the SPA refreshes the countdown in place instead of opening a new "Hive:" line.
  • soakRemainingFromReason kept as a legacy parser for pre-change records.
  • Verified: nothing on GitHub is written per pass during soak.
  • Tests in stagelabels / automerge / dashboard; docs + changelog fragment.

… the note every pass

The contributor lane reported contributor-lane:soaking(remaining=12m0s),
a reason that changed every pass; ObserveProgress restamped Reason and
LastSeen, dirtying and saving the store each pass, and the dashboard aged
the caption from LastSeen while the SPA treated each countdown text change
as a new Hive: line. The owner saw the note refresh every minute of a soak.

Record the soak head/start/window once on the stage record and report the
stable contributor-lane:soaking reason. LastSeen no longer counts as a
record change (persisted at most every 10m). The record carries
ReasonChangedAt; the dashboard sends note_changed_at and computes the time
left from the recorded deadline at request time (soak complete at/after
the deadline, never 0s left). The SPA refreshes the countdown in place for
the same note. soakRemainingFromReason stays as a legacy parser.

Closes #15758

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15748 πŸ› [reviewer] park PRs at 085 Needs decision when the fixer exhausted its attempts same files src/docs/hive-merge.md
src/pkg/dashboard/stage_tracker_build.go
src/pkg/github/automerge/automerge_stage_labels.go
#15757 ✨ Auto-merge hive-authored superseding PRs without operator decision same files src/docs/hive-merge.md
#15755 πŸ› [reviewer] carry operator decision over the hive's base refresh same files src/docs/hive-merge.md
src/pkg/github/automerge/automerge_contributor_lane.go
src/pkg/github/automerge/automerge_stage_labels.go
#15767 πŸ› Auto-resolve hive advisory checklists and fix issue-type delegated plan wording same files src/pkg/dashboard/static/index.html
#15765 πŸ› fix: advisory checklists resolve themselves and never park on a person same files src/pkg/dashboard/stage_tracker_build.go
src/pkg/dashboard/static/index.html
#15763 πŸ› merge train: ready PRs lead; odometer rolls only after the bee lands same files src/docs/hive-merge.md
src/pkg/dashboard/stage_tracker_cues_test.go
src/pkg/dashboard/static/index.html
#15308 ✨ feature: enqueue eligible PRs into GitHub native merge queues same files src/pkg/github/automerge/automerge_contributor_lane.go
src/pkg/github/automerge/automerge_contributor_lane_test.go

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stage tracker: soak note re-stamps its age every eval pass

1 participant