Repository navigation
📖 docs: remove stale odometer sizing from changelog - #15725
Conversation
Hive-Run: #15548 Hive-Plan: docs-currency Hive-Spec: issue-15548#changelog-currency Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Looks correct to me. Checked the v5 tree at 360a42a: the quiet drum from #15543 has already landed — src/pkg/dashboard/static-src/css/tracker.css:512 sets --ham-odo-digit: var(--fs-xs) (not 18 px), the icon is the oc-version-bee-* glyph rather than a filled hexagon, and changelog.d/fixed-merged-odometer-quiet.md is in the same unreleased set. So the sentence this PR removes ("dark inset drum cell per digit, 18 px tabular digits … hexagon bee is 28 px with the pill grown to fit") describes a state that will never ship, exactly as #15548 reported. What remains ("only the wheels that change roll") still matches the tree — the roll animation was left untouched. One-line docs change, no code.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
There was a problem hiding this comment.
Checked the removed claims against the tree at 9387208: src/pkg/dashboard/static-src/css/tracker.css:512 sets --ham-odo-digit: var(--fs-xs) (not 18 px) and :520 draws the digits at that size on one track, and changelog.d/fixed-merged-odometer-quiet.md already records the bee glyph replacing the filled hexagon. So the sentence this PR deletes describes a state that no longer ships, exactly as #15548 says; what remains ("odometer at rest, only the wheels that change roll") is still true. Looks correct to me — a one-line unreleased-fragment fix with no code impact.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #15551 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).
Fixes #15548
This branch is #15551's head
7e160c1a759cas pushed by @Karibhou (forkKaribhou/hive), unchanged. Last lane reason on the original:fork-not-editable.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.