Skip to content

📖 docs: remove stale odometer sizing from changelog - #15725

Merged
hivecommons-hive[bot] merged 20 commits into
v5from
hive/adopt-15551
Oct 30, 2026
Merged

hivecommons-hive[bot] merged 20 commits into
v5from
hive/adopt-15551

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #15551 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).

Fixes #15548

This branch is #15551's head 7e160c1a759c as pushed by @Karibhou (fork Karibhou/hive), unchanged. Last lane reason on the original: fork-not-editable.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Checked the v5 tree at 360a42a: the quiet drum from #15543 has already landed — src/pkg/dashboard/static-src/css/tracker.css:512 sets --ham-odo-digit: var(--fs-xs) (not 18 px), the icon is the oc-version-bee-* glyph rather than a filled hexagon, and changelog.d/fixed-merged-odometer-quiet.md is in the same unreleased set. So the sentence this PR removes ("dark inset drum cell per digit, 18 px tabular digits … hexagon bee is 28 px with the pill grown to fit") describes a state that will never ship, exactly as #15548 reported. What remains ("only the wheels that change roll") still matches the tree — the roll animation was left untouched. One-line docs change, no code.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the removed claims against the tree at 9387208: src/pkg/dashboard/static-src/css/tracker.css:512 sets --ham-odo-digit: var(--fs-xs) (not 18 px) and :520 draws the digits at that size on one track, and changelog.d/fixed-merged-odometer-quiet.md already records the bee glyph replacing the filled hexagon. So the sentence this PR deletes describes a state that no longer ships, exactly as #15548 says; what remains ("odometer at rest, only the wheels that change roll") is still true. Looks correct to me — a one-line unreleased-fragment fix with no code impact.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit ff85c5d into v5 Oct 30, 2026
74 of 76 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-15551 branch October 30, 2026 12:09
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#157259387208` sha256:00bbbbb44ba353fb91212104500b8729bedf304204386a26858efdc272f4af63 — download from the dashboard or `hivectl review evidence #15725`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (docs-currency): Earlier unreleased changelog fragment still advertises 18 px digits and a grown pill

1 participant