Repository navigation
π dashboard: sidebar Overview and activity-monitor counts explain and align their populations - #15302
Conversation
β¦ align their populations The Overview pill prints the open set as items (33 issues / 13 PRs); the Hive activity monitor pill prints the same set as rows (every issue, plus each PR not drawn under a listed issue). Nothing said so, so 33/13 beside 37 read as a disagreement. Both tooltips and the activity-monitor header now name the unit and spell out the row make-up (37 rows (33 issues + 4 PRs on their own row) Β· 9 PRs shown on their issue's row). Docs corrected; node-harness tests cover the derivation. Fixes #15295 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #15297 (earlier, CI green, same fix for #15295) or this PR lands β both cannot merge, they rewrite the same lines of stageTrackerCountsText in src/pkg/dashboard/static/index.html.
This appears to duplicate #15297, which makes the same change for #15295: both add a (N issues + M PRs on their own row) breakdown to the activity-monitor header and pill tooltip in stageTrackerCountsText (src/pkg/dashboard/static/index.html ~L17164β17190), and both replace the Overview pill tooltip with the same lead text ("β¦ the Hive activity monitor pill counts rows of this same set (every issue, plus each PR not shown under a listed issue), so it can read differently", ~L26005β26040). Same files, same src/docs/dashboard-sections.md correction, same changelog intent. I read both diffs in full.
Verified differences:
- Header note. #15297 appends
Β· 9 PRs shown on their issue's rowto the header; this PR does not β the header here is37 rows (33 issues + 4 PRs on their own row) Β· 3 need attentionand the note goes only tobadgeTitle(stage_tracker_ui_test.goadded assertion:assert.strictEqual(c.header, '37 rows (33 issues + 4 PRs on their own row) Β· 3 need attention')). The PR body says the header carries the shared-PR note too; the diff does not implement that. Minor body/diff mismatch, not a defect. - Clamping. This PR extracts
stageTrackerRowBreakdownand clampsstandalonePRstomin(prs, rows β issues); #15297 computesownPRs = max(0, allCount β issues)inline without the upper clamp. Only observable if the row count ever exceeds issues + PRs, which the row model should not produce. - This PR also updates
overview_kpi_sparklines_test.go/overview_kpi_values_10139_test.go; #15297's dashboard test shards pass without touching them, so those edits are not needed for green CI.
Either one resolves #15295; they conflict rather than stack (this PR already carries conflicts-with-open-pr). #15297 is earlier and already green. If you prefer the extracted pure helpers here, the alternative is to close #15297. I have not closed anything.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
Needs a decision, not a merge:
Head: verdict requires_human @39bcd6f, 67/70 checks green, 3 pending, DCO yes, soak 0s of 30m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
Fixes #15295
The left-menu Overview counter (
33/13) prints the canonical open set as items β open issues / open PRs. The Hive activity monitor counter (37) prints the same set as rows: every open issue is a row, a PR is its own row only when it is not drawn under a listed issue.37 = 33 issues + 4 PRs on their own row; the other 9 PRs sit on their issue's row. Verified against hive's own spoke (table in #15295).Fix keeps each section's natural unit but labels it:
33 open issues / 13 open PRs β the Hive activity monitor pill counts rows of this same set (β¦) Β· <equation>37 rows (33 issues + 4 PRs on their own row) Β· 3 need attention Β· 9 PRs shown on their issue's rowvia new purestageTrackerRowBreakdown.go build ./... && go vet && go test ./pkg/dashboard/... -racegreen.