Skip to content

πŸ› dashboard: sidebar Overview and activity-monitor counts explain and align their populations - #15302

Merged
clubanderson merged 1 commit into
v5from
fix/sidebar-counts-explain
Oct 29, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/sidebar-counts-explain

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15295

The left-menu Overview counter (33/13) prints the canonical open set as items β€” open issues / open PRs. The Hive activity monitor counter (37) prints the same set as rows: every open issue is a row, a PR is its own row only when it is not drawn under a listed issue. 37 = 33 issues + 4 PRs on their own row; the other 9 PRs sit on their issue's row. Verified against hive's own spoke (table in #15295).

Fix keeps each section's natural unit but labels it:

  • Overview pill tooltip: 33 open issues / 13 open PRs β€” the Hive activity monitor pill counts rows of this same set (…) Β· <equation>
  • Activity-monitor pill tooltip + header: 37 rows (33 issues + 4 PRs on their own row) Β· 3 need attention Β· 9 PRs shown on their issue's row via new pure stageTrackerRowBreakdown.
  • Docs: Overview + Hive activity monitor sections explain the two units (the old "all three always agree" line corrected).
  • Node-harness tests for the breakdown/tooltip derivation incl. the live 33/13 ↔ 37 case; changelog fragment.

go build ./... && go vet && go test ./pkg/dashboard/... -race green.

… align their populations

The Overview pill prints the open set as items (33 issues / 13 PRs); the
Hive activity monitor pill prints the same set as rows (every issue, plus
each PR not drawn under a listed issue). Nothing said so, so 33/13 beside
37 read as a disagreement. Both tooltips and the activity-monitor header
now name the unit and spell out the row make-up
(37 rows (33 issues + 4 PRs on their own row) Β· 9 PRs shown on their
issue's row). Docs corrected; node-harness tests cover the derivation.

Fixes #15295

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15134 πŸ› Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15297 πŸ› fix: clarify dashboard item and row counters CONFLICT src/docs/dashboard-sections.md
src/pkg/dashboard/open_items_test.go
src/pkg/dashboard/overview_sidebar_pill_test.go
src/pkg/dashboard/stage_tracker_ui_test.go
src/pkg/dashboard/static/index.html
#15253 πŸ› decision toast: issue decisions no longer read as 'approved for merge' same files src/pkg/dashboard/static/index.html
#15282 πŸ“– docs: make Hive guides easier to follow same files src/docs/dashboard-sections.md
#15301 πŸ› Let hive decide: close already-fixed PRs instead of adopting them same files src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether #15297 (earlier, CI green, same fix for #15295) or this PR lands β€” both cannot merge, they rewrite the same lines of stageTrackerCountsText in src/pkg/dashboard/static/index.html.

This appears to duplicate #15297, which makes the same change for #15295: both add a (N issues + M PRs on their own row) breakdown to the activity-monitor header and pill tooltip in stageTrackerCountsText (src/pkg/dashboard/static/index.html ~L17164–17190), and both replace the Overview pill tooltip with the same lead text ("… the Hive activity monitor pill counts rows of this same set (every issue, plus each PR not shown under a listed issue), so it can read differently", ~L26005–26040). Same files, same src/docs/dashboard-sections.md correction, same changelog intent. I read both diffs in full.

Verified differences:

  • Header note. #15297 appends Β· 9 PRs shown on their issue's row to the header; this PR does not β€” the header here is 37 rows (33 issues + 4 PRs on their own row) Β· 3 need attention and the note goes only to badgeTitle (stage_tracker_ui_test.go added assertion: assert.strictEqual(c.header, '37 rows (33 issues + 4 PRs on their own row) Β· 3 need attention')). The PR body says the header carries the shared-PR note too; the diff does not implement that. Minor body/diff mismatch, not a defect.
  • Clamping. This PR extracts stageTrackerRowBreakdown and clamps standalonePRs to min(prs, rows βˆ’ issues); #15297 computes ownPRs = max(0, allCount βˆ’ issues) inline without the upper clamp. Only observable if the row count ever exceeds issues + PRs, which the row model should not produce.
  • This PR also updates overview_kpi_sparklines_test.go / overview_kpi_values_10139_test.go; #15297's dashboard test shards pass without touching them, so those edits are not needed for green CI.

Either one resolves #15295; they conflict rather than stack (this PR already carries conflicts-with-open-pr). #15297 is earlier and already green. If you prefer the extracted pure helpers here, the alternative is to close #15297. I have not closed anything.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

Head: verdict requires_human @39bcd6f, 67/70 checks green, 3 pending, DCO yes, soak 0s of 30m0s.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves conflicts-with-open-pr Open PR has a merge conflict with another open PR dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard: sidebar Overview counter (33/13) and Hive activity monitor counter (37) look like the same number but count different units

1 participant