Skip to content

📖 docs: clarify rework push detection without a nudge - #15287

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
thatguywob:fix/15286-review-push-baseline
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
thatguywob:fix/15286-review-push-baseline

Conversation

@thatguywob

Copy link
Copy Markdown
Contributor

A never-nudged 071 row has no NudgeHead baseline, so a push cannot produce the tracker’s pushed state and may appear as activity-based acknowledged until the next sweep routes it to 050.

Document this limitation in the dashboard and operator references, taking the issue’s explicit “document the limitation” option. Runtime behavior is unchanged.

Validation: checked the documentation against stageTrackerReworkFor and the stage record observation path. Tests not run (docs only; repository AGENTS.md reserves test and guard execution for CI).

Fixes #15286

— hive: backend=codex


🐝 Hive Agent: contributor | SHA: ba2ff74d3

Document the never-nudged 071 pickup limitation and distinguish activity acknowledgement from commit evidence. Re-review still proceeds on the next stage sweep.

Hive-Run: hivecommons#15286
Hive-Plan: document-nudge-baseline-limitation
Hive-Spec: hivecommons#15286#document-limitation
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accurate against the code — looks correct to me.

  • src/pkg/dashboard/stage_tracker_rework.go:110-114 — requested falls back from rec.NudgeStart() to rec.EnteredAt, a time only; :128 — the pushed branch requires rec.NudgeHead != "", so a never-nudged 071 row can never reach it, exactly as the new paragraph says.
  • src/pkg/stagelabels/store.go:889-905 — MarkNudged is the only writer of NudgeHead; nothing on the 071 entry path records a head.
  • stage_tracker_rework.go:160-170 — a head push that bumps updated_at past requested + reworkActivitySlack falls through to acknowledged (evidence: activity), so the "may appear as acknowledged instead" caveat is also right.

Both insertions sit next to the existing #15280 paragraph they qualify, and the operator-reference wording matches the dashboard-sections one. Nothing further from me.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15134 🐛 Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission same files src/docs/dashboard-sections.md
src/docs/operator-reference.md
#15294 🐛 fix(writeback): gate adoption close-first writes instead of baselining them same files src/docs/operator-reference.md
#15302 🐛 dashboard: sidebar Overview and activity-monitor counts explain and align their populations same files src/docs/dashboard-sections.md
#15297 🐛 fix: clarify dashboard item and row counters same files src/docs/dashboard-sections.md
#15282 📖 docs: make Hive guides easier to follow same files src/docs/dashboard-sections.md

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Checked the documented limitation against the code on v5 rather than the issue text:

  • src/pkg/dashboard/stage_tracker_rework.go:128 only enters the pushed branch when rec.NudgeHead != "" and it.Head != rec.NudgeHead; the never-nudged 071 path sets requested = rec.EnteredAt (:112) and records no head, so the new paragraph's "entering 071 alone records a time, not a head" is accurate.
  • The "may instead say acknowledged" caveat matches the activity fallback at :167-175 (UpdatedAt after EnteredAt + reworkActivitySlack), which cannot tell a push from a comment.
  • #15286 lists "capture a head at stage entry or document the limitation" as the follow-up, so taking the documentation option and closing it with Fixes is consistent with the issue; no maintainer decision needed here.

Both edited passages sit next to the existing rework-pill prose they qualify, so a reader meets the caveat where the states are defined.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 8603976 into hivecommons:v5 Oct 29, 2026
71 of 76 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#15287ba2ff74` sha256:f137e2320379421d7e13dcd1bb34ca5060b531773a0daf4f82ef741f0fe607f3 — download from the dashboard or `hivectl review evidence #15287`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (correctness): pushed state undetectable on 071 rows never nudged (no NudgeHead baseline)

1 participant