Skip to content

🐛 fix(blocked): keep a relay's marker-less blocked label instead of lifting it - #15022

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/blocked-keep-relay-blocks
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/blocked-keep-relay-blocks

Conversation

@Danathar

@Danathar Danathar commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The blocked sweep lifts a contributor relay's blocked label minutes after the relay applies it, every day. The issue goes back to the ready band, the next agent finds the same blocker, posts the same comment, and the relay applies blocked again.

Evidence from projectbluefin/testsuite (every label event by hivecommons-hive[bot]):

Cause

Change

Testing

From src/, TZ=UTC, -count=1:

  • go test ./pkg/github/ ./pkg/dashboard/ passes.
  • go build ./..., go vet ./pkg/github/ and gofmt are clean.
  • check-changelog-fragment.sh v6, check-docs-links.py and check-docs-citations.py pass.
Test Covers
TestSweepBlockedIssuesKeepsRelayMarkerlessBlock (new) Three sweeps. A relay's marker-less, hive-actor block is never lifted. A review-backlog item (the #13364 case) is lifted exactly once. An item with an open native blocker, read from the listing's issue_dependencies_summary, is kept.
TestReconcileBlockedIssues (extended) #80, a relay block, is kept, has help wanted stripped, gets no timeline read and no note. #90, a review-backlog item with an open native blocker, is kept.
TestFetchWebhookItemSnapshotBlockedRowFacts (new), TestEnumerateActionableRecordsBlockedRecheckAfter (extended) Both new row facts are recorded on the webhook and enumeration paths.

Existing expectations changed in TestReconcileBlockedIssues, because their premise is the one this fixes:

Mutation checks

Eight mutants, each restored from a backup copy, and every one fails a test:

  • the review-backlog gate;
  • the native-blocker gate;
  • the sweep's summary decode;
  • each of the two row facts;
  • the webhook passing 0;
  • the enumeration passing 0;
  • the footer check forced true.

Not verified, or still open

  • A relay block on a review-backlog item still matches, because it has the footer and the hive actor. The backlog no longer writes marker-less blocks, so retiring the marker-less lift entirely may be the cleaner end state.
  • ReconcileHiveHardSuppress (🐛 hive parks its own work on hard-suppress labels (hold/blocked/needs-human) and never lifts them #12002) can still lift a relay's blocked when an App or AI PR that references the issue merges after the label. That is a rarer path and is not touched here.
  • Cached rows from before the upgrade lack review_backlog. They fail safe: the block is kept.
  • Not run on a live hive.

The other half, having the hive record the blocker that a relay's verdict names so it can lift blocked itself when that blocker closes, is a separate change: #15023.

Contributor checklist

  • Changelog: changelog.d/fixed-blocked-keep-relay-blocks.md.
  • Targets v6.
  • The title uses the emoji convention.
  • Commits include DCO sign-off.
  • Docs updated (src/docs/labels-and-control-signals.md, src/docs/scale-envelope.md).
  • No secrets, credentials or local runtime state are committed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

…ifting it

A contributor relay applies `blocked` on a blocked verdict with the
hub-minted task token, so GitHub records the hive's own App bot as the
labeled actor, and it writes no blocked-on marker by design (lifting is a
person's, hivecommons#7924, hivecommons#12376). liftBlockedMarkerless, added for
review-backlog twins (hivecommons#13364), lifted any marker-less block the hive bot
applied, so it took every relay verdict for a defect: the issue went back
to the ready band, the next agent hit the same blocker and the relay
re-applied the label, daily.

The marker-less lift now applies only to review-backlog items (body
carries reviewBacklogFooter), the one hive path it was written for, and
never while GitHub reports an open "blocked by" link (hivecommons#9839). Both facts
come from payloads the enumeration, webhook re-read and blocked sweep
already fetch: the row records them, and the sweep's listing now keeps
issue_dependencies_summary. Neither costs a timeline read: both are ruled
out before it. The pr= marker and recheck-after paths are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15029 ✨ feat(contribute): record the blocker a relay's blocked verdict names CONFLICT src/docs/labels-and-control-signals.md
#14945 🐛 fix: release label-blocked serialized lane fronts during sweeps same files src/docs/labels-and-control-signals.md

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • check-failure

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task; your current task is parked (claim kept alive) until this PR is green.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read src/pkg/github/issue_blocked.go, client.go, webhook_item_patch.go, webhook_item_refresh.go at 3f4d44c against v6, plus the fold path in review_backlog_routing.go. The change is correct and the narrowing is justified by the tree; the red CI on this head is infrastructure, not the diff.

What I verified

  • The new gate at issue_blocked.go:561-563 (!t.reviewBacklog || t.openBlockedBy > 0 → return false) runs before blockedLabelActor, so a relay block costs no timeline call and can no longer be lifted by the actor check — which indeed cannot distinguish the relay (same App bot via the task token) from the hive.
  • Both inputs come from already-fetched data: fetchIssues passes blockedCounts[...] (client.go:1871, from listOpenIssuesForEnumeration at :1786); the webhook re-read passes blockedBy from getIssueWithBlockedCount (webhook_item_refresh.go:122, :141); and listOpenBlockedIssues (issue_blocked.go:779-815) decodes issue_dependencies_summary via the existing issueWithDependencies embed (issue_dependencies.go:54-56), whose BlockedBy is documented as the OPEN-blocker count (:43-44). reviewBacklogFooter is appended by every backlog body writer (review_backlog_routing.go:526,541,568,578, review_backlog_split.go:142,152).
  • go build ./pkg/github/ passes on this head.
  • CI: test (dashboard 1/4) failed with FAIL github.com/hivecommons/hive/pkg/dashboard [setup failed] caused by proxy.golang.org … cel-go@v0.31.0 … stream error: INTERNAL_ERROR (job 122987288304); coverage then refused because a required shard did not complete. Neither touches this diff — a re-run should clear it.

Info — residual #13364 leftovers whose twin body is not a backlog filing stay stuck (issue_blocked.go:561)

The fold path already drops blocked from the labels it propagates (reusedTwinLabels, review_backlog_routing.go:323-332), so no new marker-less backlog blocks arise. Of the old ones, the twin that kept the label "loses its body" (:142-145 comment) — so a twin originally filed by a non-backlog lane carries no reviewBacklogFooter and will now never be lifted by the sweep either. That is the trade the PR body states ("every other marker-less block stays for a person"); I agree it is the right side to err on, just naming the residual so nobody expects the sweep to clean those.

Body vs diff: consistent.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/check-report (head 3f4d44c; base v6): the red is infrastructure, not the diff. test (dashboard 1/4) died downloading a module — github.com/google/cel-go@v0.31.0: read https://proxy.golang.org/...: stream error: stream ID 193; INTERNAL_ERROR; received from peer — so no src/coverage-dashboard-1.out was produced, test reports the sliced shard failed, and coverage fails because it requires every shard to succeed. No code change is needed; a fresh head (e.g. git fetch upstream v6 && git rebase upstream/v6 on fix/blocked-keep-relay-blocks, then push with the same sign-off) re-runs CI. This hive cannot re-run checks or push to your fork.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 071a132

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit e75ddd0 into hivecommons:v6 Oct 28, 2026
108 of 121 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#150223f4d44c` sha256:1d5a98753d7074807f71aacd62026977c58150502cfb34967789d02d4a68e1a7 — download from the dashboard or `hivectl review evidence #15022`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @Danathar holds role owner and GitHub permission maintain on repo; CI green at 3f4d44c.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login conflicts-with-open-pr Open PR has a merge conflict with another open PR dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant