Repository navigation
π± test(hive): stop boot-config tests binding the real pprof port - #14847
Conversation
TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarnings fails on v5 with 'registered 4 cleanups, want 3' whenever 127.0.0.1:6060 happens to be free on the runner: the fake config leaves debug.pprof_addr empty, so startRuntimeObservability binds the default listener and pushes its stop hook. Disable the listener in the fakes so the cleanup count only reflects lock, cancel and tracing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Read runtime_observability.go and config.go on v5 against this diff. Looks correct to me.
startRuntimeObservability binds whatever b.cfg.Debug.EffectivePprofAddr() returns (src/cmd/hive/runtime_observability.go:21), and that returns "" (listener disabled) when PprofAddr is the "off" sentinel (src/pkg/config/config.go:386-387, constant at :366). Setting cfg.Debug.PprofAddr = config.PprofAddrOff in both the shared fake (boot_config_deps_test.go:80) and the inline override at :356 therefore keeps the test from ever reaching the 127.0.0.1:6060 bind, so the cleanup count no longer depends on what else is listening on the CI host. Test-only.
The red relative links and anchors resolve check on this head is the v5 baseline drift in src/docs/scale-envelope.md:37, not this diff; #14846 fixes it.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
) TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarnings fails on v5 with 'registered 4 cleanups, want 3' whenever 127.0.0.1:6060 happens to be free on the runner: the fake config leaves debug.pprof_addr empty, so startRuntimeObservability binds the default listener and pushes its stop hook. Disable the listener in the fakes so the cleanup count only reflects lock, cancel and tracing. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit fb9d5ec) Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
) (#14961) TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarnings fails on v5 with 'registered 4 cleanups, want 3' whenever 127.0.0.1:6060 happens to be free on the runner: the fake config leaves debug.pprof_addr empty, so startRuntimeObservability binds the default listener and pushes its stop hook. Disable the listener in the fakes so the cleanup count only reflects lock, cancel and tracing. (cherry picked from commit fb9d5ec) Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Why
TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarningsis red onv5(e.g. run 40632216454,test (rest 4/4), on d98b765) with:The test fakes return a
config.Configwithdebug.pprof_addrunset, sostartRuntimeObservability(#14681) tries to bind the default127.0.0.1:6060listener and β only when that port is free on the runner β pushes a 4th cleanup. Whether the assertion passes therefore depends on what else is listening on the CI host (and on test order, since this test never runs its cleanups and leaks the listener to its siblings).Set
PprofAddr = config.PprofAddrOffin both fake configs so the boot phase never opens a real socket from a unit test and the cleanup count is deterministic (lock, cancel, tracing). Test-only change; no changelog fragment.β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88