Skip to content

🌱 test(hive): stop boot-config tests binding the real pprof port - #14847

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-bootconfig-pprof-flake
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-bootconfig-pprof-flake

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Why

TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarnings is red on v5 (e.g. run 40632216454, test (rest 4/4), on d98b765) with:

boot_config_deps_test.go:374: registered 4 cleanups, want 3

The test fakes return a config.Config with debug.pprof_addr unset, so startRuntimeObservability (#14681) tries to bind the default 127.0.0.1:6060 listener and β€” only when that port is free on the runner β€” pushes a 4th cleanup. Whether the assertion passes therefore depends on what else is listening on the CI host (and on test order, since this test never runs its cleanups and leaks the listener to its siblings).

Set PprofAddr = config.PprofAddrOff in both fake configs so the boot phase never opens a real socket from a unit test and the cleanup count is deterministic (lock, cancel, tracing). Test-only change; no changelog fragment.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarnings fails
on v5 with 'registered 4 cleanups, want 3' whenever 127.0.0.1:6060 happens
to be free on the runner: the fake config leaves debug.pprof_addr empty, so
startRuntimeObservability binds the default listener and pushes its stop
hook. Disable the listener in the fakes so the cleanup count only reflects
lock, cancel and tracing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible β€” a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking β€”
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly β€” that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read runtime_observability.go and config.go on v5 against this diff. Looks correct to me.

startRuntimeObservability binds whatever b.cfg.Debug.EffectivePprofAddr() returns (src/cmd/hive/runtime_observability.go:21), and that returns "" (listener disabled) when PprofAddr is the "off" sentinel (src/pkg/config/config.go:386-387, constant at :366). Setting cfg.Debug.PprofAddr = config.PprofAddrOff in both the shared fake (boot_config_deps_test.go:80) and the inline override at :356 therefore keeps the test from ever reaching the 127.0.0.1:6060 bind, so the cleanup count no longer depends on what else is listening on the CI host. Test-only.

The red relative links and anchors resolve check on this head is the v5 baseline drift in src/docs/scale-envelope.md:37, not this diff; #14846 fixes it.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit fb9d5ec into v5 Oct 28, 2026
88 of 95 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-bootconfig-pprof-flake branch October 28, 2026 05:26
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#148472374885` sha256:f32cc6b42f2e1b3fef51e0d610aec6d05b64c428a3b8237217fe15714385288f β€” download from the dashboard or `hivectl review evidence #14847`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 28, 2026
hivecommons-hive Bot added a commit that referenced this pull request Oct 28, 2026
)

TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarnings fails
on v5 with 'registered 4 cleanups, want 3' whenever 127.0.0.1:6060 happens
to be free on the runner: the fake config leaves debug.pprof_addr empty, so
startRuntimeObservability binds the default listener and pushes its stop
hook. Disable the listener in the fakes so the cleanup count only reflects
lock, cancel and tracing.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit fb9d5ec)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Oct 28, 2026
) (#14961)

TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarnings fails
on v5 with 'registered 4 cleanups, want 3' whenever 127.0.0.1:6060 happens
to be free on the runner: the fake config leaves debug.pprof_addr empty, so
startRuntimeObservability binds the default listener and pushes its stop
hook. Disable the listener in the fakes so the cleanup count only reflects
lock, cancel and tracing.




(cherry picked from commit fb9d5ec)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants