Skip to content

🌱 test(hive): stop boot-config tests binding the real pprof port on v6 - #14961

Merged
hivecommons-hive[bot] merged 1 commit into
v6from
scanner/fix-boot-config-cleanup-count
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v6from
scanner/fix-boot-config-cleanup-count

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Closes #14960

test (rest 4/4) went red on v6 HEAD 44534cd with "registered 4 cleanups, want 3" while the two previous v6 commits passed the same shard without touching src/cmd/hive. Since #14682 the pprof listener pushes a cleanup only when it binds 127.0.0.1:6060, and the boot-config fakes leave debug.pprof_addr empty, so the expected count flips with the runner's port state.

v5 already fixed exactly this in #14847 (fb9d5ec); v6 has not received it yet. This is a straight cherry-pick -x of that commit so the next v5→v6 forward-merge sees identical content instead of a conflicting hand-rolled variant. Test-only; no changelog fragment.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
)

TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarnings fails
on v5 with 'registered 4 cleanups, want 3' whenever 127.0.0.1:6060 happens
to be free on the runner: the fake config leaves debug.pprof_addr empty, so
startRuntimeObservability binds the default listener and pushes its stop
hook. Disable the listener in the fakes so the cleanup count only reflects
lock, cancel and tracing.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit fb9d5ec)
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive
hivecommons-hive Bot force-pushed the scanner/fix-boot-config-cleanup-count branch from ed29017 to 80b108f Compare October 28, 2026 14:17
@hivecommons-hive hivecommons-hive Bot changed the title 🌱 test(hive): make the boot cleanup-count assertion independent of port 6060 🌱 test(hive): stop boot-config tests binding the real pprof port (v6 cherry-pick of #14847) Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot changed the title 🌱 test(hive): stop boot-config tests binding the real pprof port (v6 cherry-pick of #14847) 🌱 test(hive): stop boot-config tests binding the real pprof port on v6 Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 42528e4 into v6 Oct 28, 2026
82 of 88 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-boot-config-cleanup-count branch October 28, 2026 14:43
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#1496180b108f` sha256:d019cf21ceb30eb9a475de76cccfafa5035a70e252cf6f776acee4303eb168fa — download from the dashboard or `hivectl review evidence #14961`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] v6 red: TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarnings cleanup count depends on port 6060

0 participants