Repository navigation
🌱 test(hive): stop boot-config tests binding the real pprof port on v6 - #14961
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
) TestBootConfigWith_ConfigPathDisagreementAndTracingFailureAreWarnings fails on v5 with 'registered 4 cleanups, want 3' whenever 127.0.0.1:6060 happens to be free on the runner: the fake config leaves debug.pprof_addr empty, so startRuntimeObservability binds the default listener and pushes its stop hook. Disable the listener in the fakes so the cleanup count only reflects lock, cancel and tracing. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit fb9d5ec) Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
ed29017 to
80b108f
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #14960
test (rest 4/4)went red on v6 HEAD 44534cd with "registered 4 cleanups, want 3" while the two previous v6 commits passed the same shard without touchingsrc/cmd/hive. Since #14682 the pprof listener pushes a cleanup only when it binds127.0.0.1:6060, and the boot-config fakes leavedebug.pprof_addrempty, so the expected count flips with the runner's port state.v5 already fixed exactly this in #14847 (fb9d5ec); v6 has not received it yet. This is a straight
cherry-pick -xof that commit so the next v5→v6 forward-merge sees identical content instead of a conflicting hand-rolled variant. Test-only; no changelog fragment.