Repository navigation
🐛 fix: enable tool-less Copilot ioscan classifiers - #14502
thatguywob wants to merge 3 commits into
Conversation
Fall back to a configured tool-less agent CLI when no classifier endpoint is available and surface unavailable fail-closed classifiers on the dashboard. Hive-Run: hivecommons#14499 Hive-Plan: issue-14499-proposed-fix Hive-Spec: issue-14499#proposed-fix Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@thatguywob is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this repository have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Another agent tried to open a PR from |
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #14502 should be closed in favour of #14501, which makes the same #14499 change plus the dashboard settings UI/validation updates this PR omits.
This appears to duplicate #14501, which makes the same change for #14499. I read both diffs in full against v5:
src/pkg/ioscan/cli_client.go— both addcopilottocliToollessArgswith an--available-toolssentinel that names no tool,--disable-builtin-mcps --no-custom-instructions --no-ask-user --no-auto-update, silent output, prompt delivered as the-pvalue instead of stdin, and acopilotentry incliEnvAllowlistthat excludesGH_TOKEN/GITHUB_TOKEN.src/cmd/hive/ioscan_classifier_boot.go— both fall back to a configured agent's tool-less backend whenioscan.classifier.backendis empty andResolveReviewer()yields no endpoint, and both raise/clear a persistent dashboardSystemAlertwhen the fail-closed classifier cannot run.
Concrete differences I verified:
- This PR does not touch
src/pkg/dashboard/static/index.html: the Classifier backend<select>(index.html:48996-48999 on v5) still has nocopilotoption and the help text at :48995 still says "copilot, codex and gemini cannot run without tools and are refused at boot", which becomes untrue once this merges. The rejection message insrc/pkg/dashboard/api_governor_security.go:128likewise still reads "must be empty or claude". #14501 updates all three. - Fallback choice: this PR takes the first tool-less backend in agent-name order (
ioscan_classifier_boot.gofallback loop); #14501 takes the backend most agents use, ties by name. Alert IDs differ (ioscan-classifier-unavailablevsioscan-classifier-blocked). Both are reasonable; they cannot both land. - #14501 is by the repository owner, has a passing CI run on its head, and includes a live tool-lessness verification in its body; this PR is
stage/072-returned-to-contributorwith its CI run still queued.
Flagging for a maintainer: if you agree, this one could be closed in favour of #14501. I have not closed anything.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #14502 is closed in favour of #14501, which makes the same #14499 change with broader dashboard coverage.
This appears to duplicate #14501, which makes the same change for #14499 and cannot merge alongside it (both rewrite the same hunks of src/pkg/ioscan/cli_client.go, src/cmd/hive/ioscan_classifier_boot.go and src/cmd/hive/main.go).
I read both diffs in full. Same semantic change in both:
copilotadded tocliToollessArgswith--available-tools <sentinel> --disable-builtin-mcps --no-custom-instructions --no-ask-user --no-auto-update --no-color -s/--silent, prompt delivered via-pinstead of stdin (cli_client.go:152-160here;cli_client.go:201-213in #14501)COPILOT_HOME/COPILOT_GITHUB_TOKENadded tocliEnvAllowlist, hiveGH_TOKEN/GITHUB_TOKENstill excluded- boot falls back to a configured agent's tool-less backend when
ioscan.classifier.backendis empty andResolveReviewer()yields no endpoint - persistent dashboard
SystemAlertwhen the classifier is fail-closed and cannot run
Differences I verified, all in #14501's favour:
src/pkg/dashboard/static/index.html:48998— this PR leaves the Settings → Security<select>without acopilotoption, so an operator who picks copilot still sees "copilot — refused at boot" even though boot now accepts it. #14501 adds the option and updates the help text and theapi_governor_security.go:128error string (which here still says "must be empty or claude").src/cmd/hive/main.go:2778— this PR passesb.dashSrv(a*dashboard.Server) straight into the variadicioscanAlertSinkslice;ClearSystemAlertis then called unconditionally atioscan_classifier_boot.go:32, andServer.ClearSystemAlert(server.go:2669) lockss.systemAlertsMuon the receiver. #14501 nil-guards the alerter before use (main.go:2778-2781,raiseIoscanClassifierAlert/clearIoscanClassifierAlert). Only matters ifnewServerever returns nil, so I note it as a difference, not a defect.- Fallback choice: this PR takes the first supported backend in agent-name order (
ioscan_classifier_boot.go:52-62); #14501 takes the backend most agents use, ties by name. Either is defensible; the issue does not specify.
#14501 is the repository owner's own PR, carries a hand-verified tool-lessness log for Copilot CLI 1.0.103, and is already green on build/test/coverage. Flagging for a maintainer: if you agree, this one could be closed in favour of #14501. I have not closed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
|
Needs a decision, not a merge:
Head: verdict requires_human @9147b51, 47/49 checks green, 2 pending, DCO yes, soak 0s of 30m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
@thatguywob this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
Decision needed (@hivecommons): #14501 already merged and closed the claimed issue, but this PR touches files the merged PR did not. Recommended: keep open until the extra changes are reviewed, or close as superseded if they are not wanted. Another option: merge anyway. Files the merged PR did not touch: This comment is edited in place by the supersession sweep; it is not duplicated. |
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
|
/hive decision close — superseded by #14501 (merged), which makes the same #14499 change with broader dashboard coverage. Thanks @thatguywob; nothing further needed here. |
|
|
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@thatguywob the hive has adopted this PR ( |
|
Closing per the maintainer ruling above (/hive decision close): superseded by #14501, merged to v5 at 2026-10-27T02:16Z, which lands the same #14499 fix (issue now closed). Nothing further to rebase here — thanks @thatguywob. |
Fixes #14499
Copilot-only hives at ACMM L5+ can now run the ioscan classifier through Copilot CLI with tools and built-in MCPs disabled, a scrubbed environment, and the prompt passed as a
-pargument. Only Copilot subscription credentials are forwarded; hive GitHub tokens remain excluded.When no endpoint or explicit classifier backend is configured, boot selects a supported configured agent CLI in agent-name order. Explicit backend settings and HTTP endpoint priority are preserved. A required classifier that cannot be constructed raises a persistent dashboard error explaining that kicks are blocked and how to restore classification or configure fail-open.
Added regression coverage for Copilot arguments/environment/prompt delivery, fallback and endpoint precedence, explicit backend selection, and alert lifecycle. Updated operator documentation and added a changelog fragment.
Validation: gofmt and git diff --check passed. Tests are reserved for CI by AGENTS.md and were not run locally.
— hive: backend=codex model=gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:959d3d8c2