Skip to content

Review backlog (correctness): Unavailable-classifier alert covers construction failures only, not runtime fail-closed #14509

Closed

Description

@hivecommons-hive

Blocked on PR #14502. This finding came from reviewing PR #14502 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #14502.

PR: #14502 (#14502)
Perspective: correctness
Severity: low (P3)
Evidence: src/cmd/hive/ioscan_classifier_boot.go:69 (

)
Finding: Unavailable-classifier alert covers construction failures only, not runtime fail-closed

alertUnavailable() is called only when NewCLIClassifier/NewLLMClassifier fail (ioscan_classifier_boot.go:69,97). With automatic copilot fallback, a hive whose Copilot CLI authenticates only via the scrubbed GH_TOKEN (cli_client.go:67-71) gets a classifier that errors on every call; at L5-L6 kicks remain blocked with no dashboard banner. Pre-existing for claude; follow-up should raise the alert from the fail-closed enforcement path.

Fingerprint: 74d151d23cb06809094196644c9e098a95c146b01176c8d52a72e7f4a42279fa

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 27, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 27, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 27, 2026
  4. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14501 (superseding #14502) is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 27, 2026
  6. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14501 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  7. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  8. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions