Skip to content

πŸ“– docs: point admin MCP links at the v6 reference so the v5 link check passes - #12161

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
scanner/fix-v5-admin-mcp-links
Oct 15, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
scanner/fix-v5-admin-mcp-links

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Summary

The v5 default branch is red on relative links and anchors resolve: #12143 linked src/docs/documentation-map.md and src/docs/troubleshooting.md to admin-mcp.md, but that document (and the adminmcp package) exists only on v6. Every open v5 PR inherits the failure (#12150, #12156, #12158 and others).

This points both links at the v6 document on GitHub and marks the feature as v6, so v5 readers still reach the reference while the local-file link check passes.

Refs #12119 (docs link follow-up; the original fix landed in #12143 and remains on v5 β€” nothing left to track there after this merges)

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 requested_by=@Danathar

scanner and others added 2 commits October 15, 2026 14:57
…sses

The admin MCP reference (admin-mcp.md) only exists on v6; #12143 linked
to it as a local file on v5, which broke the 'relative links and anchors
resolve' check on the v5 default branch and on every open PR.

Signed-off-by: scanner <scanner@hive.kubestellar.io>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 15, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Changelog fragment needed

This PR changes code under src/ but has no changelog.d/ fragment and no no-changelog label, so the changelog-fragment-guard check fails.

Pick one:

A. The change is user-visible (feature, fix, new env var, behavior/security change) β€” add one file and push:

# category: added | changed | deprecated | fixed | security
echo '- <one-line entry in the style of CHANGELOG.md>' > changelog.d/<category>-12161.md
git add changelog.d && git commit -s -m "changelog: fragment for #12161"

B. Not user-visible (refactor, internal test plumbing, CI) β€” ask a maintainer to add the no-changelog label.

Do not edit CHANGELOG.md directly; the release compiler assembles it from fragments (see changelog.d/README.md, #5675). This comment is removed automatically once the check passes.

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

  • Claimed issue: hive#12119
  • Closing PR: #12143

this PR touches files the merged PR did not. A human should decide whether to close this PR.

This comment is edited in place by the supersession sweep; it is not duplicated.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

βœ… Escalation cleared β€” back in the automated lane

CI is green on the current head β€” returning this PR to the automated lane.

The needs-human label has been removed; the fix loop owns this PR again.

@hivecommons-hive
hivecommons-hive Bot merged commit 51320b7 into v5 Oct 15, 2026
66 of 68 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-v5-admin-mcp-links branch October 15, 2026 19:23
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants