Skip to content

πŸ› dashboard: covered-by-PR glyph from hive's claim evidence; never closing-link a reference claim - #12152

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
fix/covered-pr-glyph
Oct 15, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
fix/covered-pr-glyph

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #12144

Root cause of the stray #12025β†’#12005 closing link

claimsFromPR runs the branch-name heuristic whenever the title/body carry no closing keyword. PR #12025's branch is feat/12005-push, so issue 12005 became a strong claim (neither Closing nor Reference), and the body's explicit Refs #12005 (partial …) was dropped because the issue already had a strong claim. #12092 changed the link gate from claim.Closing to !claim.Reference, so on the first sweep after it deployed (17:41Z, two hours after Bob had removed Closes #12005 from the body) the branch-name claim got addCloseIssueReferences. Not a stale body or a stale memo β€” a grading bug.

Changes

pkg/github

  • claimsFromPR: an explicit non-closing reference to the branch-name issue downgrades the branch-name claim to a reference claim. Closes #N still beats both; Refs #other still adds a separate weak claim.
  • New Client.RetractHiveClosingIssueLink: for a reference claim the sweep looks up the PR's closingIssuesReferences and CONNECTED_EVENT timeline. If the pair is linked and the most recent connect actor is this hive's App account (appBotLogin, compared without [bot]), it runs removeCloseIssueReferences and forgets the ensure-memo so a later Closes #N edit re-links. A link made by a person β€” or seen by a PAT-authenticated hive that cannot tell its own links apart β€” is left alone and logged at Warn (not-hive-linked). Memoised per pair; failures are not memoised.
  • RepoWorkIssue (the nonActionableIssues entry a suppressed issue becomes) now carries linked_prs and claim_context; IssueLinkedPR gains reference.

Dashboard (static/index.html)

  • New issueCoveringPR / issueCoveringPRBadge: the πŸ”— pill is derived from linked_prs β€” hive's own claim evidence, the same source that applies 🐝 covered by PR β€” and used by both the actionable and the non-actionable pill renderers. Tooltip: "closes via PR #N" / "covered by PR #N (partial)" / "merged via PR #N". Exactly one badge per issue; several PRs β†’ closing one primary, πŸ”—Γ—2, rest in the tooltip. Non-actionable rows also get the issue:linked-pr filter kind. Reuses .repo-issue-plan.pill-icon and repoPillActionCluster; no inline styles or raw px (ratchet counts unchanged).

Tests: prclaims_branch_reference_12144_test.go (claim grading incl. the #12025 shape, retraction matrix, sweep retracts + never adds for reference claims, suppressed issue keeps linked_prs), repo_card_covering_pr_glyph_12144_test.go (node-executed badge assertions).

Docs: dashboard.md (Linked PR issue signals), dashboard-sections.md (Repositories pills), labels-and-control-signals.md (covered-by-PR row: link rule + retraction).

Live check before the change (/api/status on hive's hive): #12002 and #12005 both sat in nonActionableIssues with reason: Open external PR #N covers this issue and no linked_prs β€” which is why the label showed and the glyph did not.

…ence claim

A PR whose body says Refs #N but whose branch is named after the issue
(feat/12005-push) was graded as a strong branch-name claim, so the link
sweep gave #12025 a GitHub closing link onto #12005 β€” arming auto-close
on merge for a deliberately partial PR. The explicit reference now
downgrades the branch-name claim, the sweep retracts closing links the
hive App itself made for reference-only pairs, and the repo card derives
its covering-PR glyph from linked_prs on actionable and suppressed
issues alike, with closing vs partial spelled out in the tooltip.

Fixes #12144

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 15, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#12158 ✨ review: add review.shadow to record would_have_held for the review gate same files src/pkg/dashboard/static/index.html
#12079 πŸ› evidence: capture CI conclusion at merge-eligibility time same files src/pkg/github/client.go
#12139 ✨ dashboard settings: expose intent pattern lists and sentinel list keys same files src/pkg/dashboard/static/index.html
#12045 πŸ› Stop task-list sweep hard-parking issues on prose needs-human same files src/docs/labels-and-control-signals.md
#12159 ✨ dashboard: iPhone widget entry in the avatar menu deep-links into Scriptable same files src/pkg/dashboard/static/index.html
#12164 🌱 tokens: per-issue/PR/head-SHA launch attribution over the token collector same files src/pkg/dashboard/static/index.html
#12154 🌱 tokens: trajectory review β€” skip only on proven-idle agent state and not overdue, with skipped metrics same files src/pkg/dashboard/static/index.html

…citation

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: the only red check here, relative links and anchors resolve, is red on the v5 default branch itself (broken admin-mcp.md links from #12143). Tracked as shared incident #12162; fix in #12161. No change needed on this branch β€” deferring until the baseline is green, then the sweep merges on re-run.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1

@hivecommons-hive
hivecommons-hive Bot merged commit a4cb8b9 into v5 Oct 15, 2026
67 of 69 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 3483a91.

@kubestellar-prow
kubestellar-prow Bot deleted the fix/covered-pr-glyph branch October 15, 2026 19:09
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐝 covered by PR glyph is inconsistent; reference claims from branch-name PRs get a GitHub closing link

1 participant