Skip to content

πŸ› Make the legacy LiteLLM endpoint findable in Settings and keep it in step with the litellm gateway - #12057

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-9945
Oct 15, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-9945

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Gap (#9945 reopen): #11794 made route diagnostics tell operators to reconcile the "legacy endpoint" (governor.litellm.endpoint, "LiteLLM tab"). But the standalone LiteLLM settings tab was retired: renderGovLiteLLM still exists, but nothing calls it, and renderGovernorTab has no LiteLLM case. That left the legacy endpoint, key and default model editable only in hive.yaml. The reporter asked "What is a legacy endpoint and where do I go to set it?" and the honest answer was "nowhere in the UI".

Saving gateway litellm with a new endpoint also left the legacy block pointing at the OLD proxy, and the legacy key store synced only when the endpoints already matched. On builds that resolve the legacy endpoint first (and on legacy-only paths), agents sent the new key to the old proxy and got 401, while the Gateways Test passed.

Fix:

  • Settings β†’ Model Gateways now has a collapsible Legacy LiteLLM endpoint (governor.litellm) section. It reuses the existing renderGovLiteLLM editor (Endpoint, API Key, Default Model, Test Connection) and saves through the existing litellm config section. No new inline styles; it uses the card-inset / mt-4 / fs-sm utilities.
  • Saving the gateway named litellm (kind litellm) with a different endpoint repoints governor.litellm.endpoint to it. It also carries over the default model and syncs the legacy key store from the submitted key, or from the gateway's stored key if none was submitted. The two can no longer diverge. Gateways with other names are left alone.
  • Route diagnostics now name the location (Settings β†’ Model Gateways β†’ Legacy LiteLLM endpoint) instead of the non-existent "LiteLLM tab". The setup dialog and welcome-tour hints no longer point at "Settings β†’ LiteLLM".
  • Docs (docs/inference-backends.md) and changelog fragment.

Tests:

  • Upsert repoints the legacy endpoint, model and key store.
  • A differently-named litellm gateway leaves the legacy block alone.
  • The Model Gateways tab renders the legacy editor, and no "Settings β†’ LiteLLM" hint remains.
  • Diagnostics name the Settings location.

Refs #9945 (needs-human: reporter must retest on the FMA hive after the fix ships in a tagged release)

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@MikeSpreitzer

…th the litellm gateway

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <scanner@hive.kubestellar.io>
Co-authored-by: MikeSpreitzer <14296719+MikeSpreitzer@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 15, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#12051 πŸ› fix(automerge): gate contributor-lane unattended merge on vetted identity same files src/pkg/dashboard/static/index.html
#12058 🌱 dashboard: unique, section-specific sidebar nav icons same files src/pkg/dashboard/static/index.html
#12061 πŸ› Explain why a scheduled hive upgrade window was held same files src/pkg/dashboard/static/index.html

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants