Repository navigation
🌱 sync: forward-merge v5 into v6 (top-up), renumber planning-engine ADR to 0022 - #10802
hivecommons-hive[bot] wants to merge 53 commits into
Conversation
Signed-off-by: scanner <scanner@hive.kubestellar.io>
…bels Signed-off-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: arteeh <35239587+arteeh@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <scanner@hive.kubestellar.io>
…st the guard test Signed-off-by: scanner <scanner@hive.kubestellar.io>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
✨ feat: contributor quota guard HIVE_CODEX_AUTO_USE_BANKED_RESET opt-in
🐛 fix: Most effective models filters, run rates and local-registry labels
📖 docs: record opt-in Codex reset redemption ruling and allow-list the guard test
Signed-off-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
* 🐛 fix: show stable next update status Use the stable promotion status as the single source for stable-channel next-update ETAs, carry an explicit queued/none/unknown status through heartbeat and dashboard APIs, and render the status on both spoke and hub fleet views. Fixes #10187 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> * changelog: fragment for #10729 Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> * 🐛 fix: remove unused stable ETA wrapper Keep the stable next-update helper as the HubServer method used by heartbeat and Fleet rows so lint stays clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* fix dashboard overview totals math Signed-off-by: Andy Anderson <andy@clubanderson.com> * changelog: fragment for #10727 Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> --------- Signed-off-by: Andy Anderson <andy@clubanderson.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ltip (#10735) * 🐛 dashboard: stop nesting a <button> inside the Overview KPI card tooltip The held/blocked/outside term tooltip rendered an "open Settings → …" <button> inside <button class="overview-kpi">. The HTML parser closes an open button when it meets a nested one, so the KPI card ended early and the rest of the tooltip plus the remaining equation terms rendered inline, overflowing the card grid (seen on hosted spoke oke-11, hive 5.136.0). Render the control as <span role="button" tabindex="0"> with the existing data-keydown-action pattern so click and keyboard still open Settings. Signed-off-by: Andrew Anderson <andy@clubanderson.com> * changelog: fragment for #10735 Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The topbar is intentionally fixed (not sticky) again on this branch; the contract test still asserted the sticky rule and failed every shard. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <scanner@hive.kubestellar.io>
Admin-merging: workflow+docs only change; all 52 code checks green, the remaining arm64 image build is unrelated to a runs-on pin and is queued behind the fleet. Unblocks stable promotion (#10042).
…-level 🐛 dashboard: ACMM Eval collapsed pill shows the current level only
Signed-off-by: Andy Anderson <andy@clubanderson.com>
…t be clipped (#10739) * 🐛 dashboard: portal version popover out of sidebar Signed-off-by: Andy Anderson <andy@clubanderson.com> * changelog: fragment for #10739 Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> --------- Signed-off-by: Andy Anderson <andy@clubanderson.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
🐛 dashboard: restore top navbar and Overview tile layout
…ress claims (#10736) * 🐛 fix(claims): escalate instead of re-claiming after 2 no-progress agent claims The claim ledger now remembers each agent's claims per issue (with how each ended), and a scheduler in-flight gate withholds a free issue whose last escalate_after_claims claims by one agent were followed by no linked or referencing PR, referencing commit, label/assignee change or close/reopen. The issue is labelled needs-human and gets one comment listing the claims (ADR-0019). Timeline read failures fail open. NOT FOR MERGE AS-IS: agent kick claims are recorded for every issue in a kick's list (up to governor.kick_limits.max_issues, default 100), so with the default threshold of 2 this would label the whole untouched backlog needs-human about four hours after deploy. See the issue comment. Hive-Run: #10527 Hive-Plan: #10527 (Proposed fix) Hive-Spec: #10527#acceptance Signed-off-by: Danathar <Danathar@users.noreply.github.com> * fix: escalate stalled claims instead of re-claiming; record claims only on start signal Kick-listed issues get a short in-ledger listing (no GitHub comment, not a claim attempt) that keeps relay contributors and other agents off them while the kick is live. The agent claim, with its comment, is recorded on the agent's first start signal on the issue: its own comment, label or claim request through the issue relay, or a PR request naming it. The escalation gate therefore counts real claims only. A likely-done issue an agent already verified after the merged PR is withheld from kicks until a person comments, labels, assigns, closes or reopens it (verify once, #10509). Refs #10527 Signed-off-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: shift scale-envelope client.go citation for the 3-line Client struct addition Signed-off-by: scanner <scanner@hive.kubestellar.io> --------- Signed-off-by: Danathar <Danathar@users.noreply.github.com> Signed-off-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…es, composite-only motion) (#10741) * 🐛 dashboard: smooth upgrade bee animation Signed-off-by: Andy Anderson <andy@clubanderson.com> * changelog: fragment for #10741 Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> --------- Signed-off-by: Andy Anderson <andy@clubanderson.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
hive/awaiting-ci: pushed 9aaab16 — 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Spot-checked the resolution table against the merged tree @9aaab16. Everything I could verify textually holds; I could not compile or run tests on this host, so CI remains authoritative for the Go side.
Verified:
- ADR renumber is complete.
src/docs/adr/0021-opt-in-earned-codex-reset-redemption.mdand0022-planning-engine-boundary.mdboth exist;src/docs/adr/README.md:58-60lists 0020/0021/0022 in order; a grep forADR-0021acrosssrc/**/*.{go,md,yaml}finds no remaining planning-engine references (only the Codex-reset ones that should stay). main.goport.src/cmd/hive/main.go:7483callsrecordAgentKickListingsinside the v6dispatchAgentKicksblock (:7443);installClaimAdmissionCheckis wired at:3505; norecordAgentKickClaimsreference remains anywhere undersrc/.index.htmlcarries v5'sheldIssues/heldPRs/blockedIssuesKPI code (16 refs) androle="button"(11 refs), as the table says.- No leftover conflict markers under
src/orbin/; everychangelog.d/fragment name uses a valid category prefix.
Not verified (no working Go toolchain here): that the style_ratchet_test.go baselines match the merged tree and that the v2-ci per-package coverage floors still hold — past v5→v6 top-ups have tripped those (e.g. #8854, #8886). CI will settle both.
One action for the merging maintainer: as the body says, merge with a merge commit, not squash, so v6 records v5 as a parent. The DCO failure is the usual forward-merge artefact (other authors' commits) and not something this PR can fix.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
hive/awaiting-ci: the only red check is probot DCO, caused by 13 pre-existing merge commits already on 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
…0797 Signed-off-by: scanner <scanner@hive.kubestellar.io> # Conflicts: # src/docs/adr/README.md
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 3 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: DCO Raw failure evidence (from check-run annotations): Remove the |
There was a problem hiding this comment.
Scoped review only — this is a 53-commit / 166-file forward-merge and I did not read the merged bulk. What I did verify at 28457ad:
- ADR renumbering is consistent.
src/docs/adr/has0021-opt-in-earned-codex-reset-redemption.mdand0022-planning-engine-boundary.md;README.md:60-61lists them in order. Every remainingADR-0021reference in the tree (pkg/rotation/codex_reset_redeem.go,cmd/hive-quota-publisher/main.go,docs/env-vars.md:413, the codex-reset changelog fragment) is a Codex-reset reference, and there are no stale0021-planning-enginepaths. 17 files now referenceADR-0022. Matches the resolution table. - The only red check is probot
DCO, which fails on every forward-merge that carries other people's commits; it is not caused by this PR.build (linux/arm64)was still pending when I looked.
Info, not a defect of this merge: src/docs/adr/README.md:58-59 still lists two ADRs numbered 0020 (0020-external-work-source-boundary.md and 0020-spek-continuous-convergence.md). That collision already exists on v6 before this PR, so it's out of scope here, but since you were renumbering in the same file a follow-up could resolve it the same way.
For a maintainer: the body asks for a merge commit, not a squash so v6 records v5 as a parent — the one question a human needs to settle is whether CI (coverage gate, style ratchet baselines set by hand in webstatic/style_ratchet_test.go) goes green on this head; the author notes tests were not run locally. I have not reviewed the main.go or index.html conflict resolutions.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Reviewer adjudication: DE-ESCALATE — evidence: the only failing check is probot DCO; the 13 unsigned commits are hivecommons-hive[bot] squash-merge commits from already-merged v5 PRs (#10784, #10796, …) carried by this forward-merge, which DCO probot cannot verify — the known non-blocking false positive on v5→v6 syncs. Branch is 0 behind v6 (compare v6...head: ahead 53, behind 0), no files removed, test-file changes are additive (≈30 added/extended _test.go files, no test deletions), so the merge is lossless. changes: none needed — no rebase required since the branch is already current with v6 (and the diff carries .github/workflows/ files, which this tier cannot push anyway). tests: all GitHub Actions checks pass/skip except DCO; tide pending on approved/lgtm. remaining risk: none beyond the standard forward-merge; admin-merge should ignore DCO as on prior syncs (#8793, #8886).
— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Conflict status at The branch was 0 behind
Overlapping paths: Suggested human step: 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
this PR touches files the merged PR did not. A human should decide whether to close this PR. This comment is edited in place by the supersession sweep; it is not duplicated. |
Hand-resolved forward-merge of v5 into v6 (48 commits, merge-base
43d631fd). Merge with a merge commit, not a squash, so v6 records v5 as a parent and the next top-up does not hit the same conflicts again.Resolution table
src/docs/adr/README.mdADR-0021: Opt-in redemption of earned Codex resets, so that one keeps 0021. Rangit mv 0021-planning-engine-boundary.md→0022-planning-engine-boundary.mdand updated its title. The index rows are in numeric order: 0020, 0021 (Codex resets), 0022 (planning engine).ADR-0021toADR-0022indocs/spektacular.md,docs/integrations/spektacular.md,cmd/hive/spektacularwire{,_test}.go,pkg/planengine/*,pkg/spektacular/*,pkg/config/runs_config.go,pkg/dashboard/server.goand the 3 planning-engine changelog fragments. The Codex-reset references stay ADR-0021:rotation/*,hive-quota-publisher,env-vars.mdand its changelog fragment.src/cmd/hive/main.godispatchAgentKicks/kickDispatchDepsafter the first status publish (#7232/#8659), and dropped v5's copy of the block at the old location. Ported v5's #10527 change (c200b46) into v6'sonDeliveredhook:recordAgentKickClaims→recordAgentKickListings, so the claim is recorded on the agent's first start signal. v5's other main.go hunks auto-merged: the #10751installClaimAdmissionCheck(7841757) and theverifyOnceLookup/claimEscalationLookupin-flight gates. The v5 tests (claims_admission_test.go,claimswire_test.go,claimescalation_test.go,verifyonce_test.go) are kept unchanged and target the same functions.src/pkg/dashboard/static/index.htmlheldIssues/heldPRs/blockedIssues/blockedPRsand total-partition sublines and uses<div role="button">instead of a nested<button>(#10770/#10772/#10741/#10732;dashboard_navbar_overview_static_test.goasserts this). The v6 side only differed by joined-line whitespace. The rest of v6's dashboard is unchanged.src/pkg/dashboard/webstatic/style_ratchet_test.gosrc/docs/integration-guide.mdvibe-kanban (report-only)row.src/docs/labels-and-control-signals.mdneeds-humanrow, which adds the claim escalation gate. Kept onegovernor.labels.exemptrow with v6's citations, which point at v6's split config files.Notes
discord_commands_test.go,identity_setters_test.goandspektacular/adapter_test.gowere already deleted on v6 before this merge, and v5 has not changed them since the merge-base.Closes #10797
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88