Skip to content

πŸ“– docs(adr): v6 addendum to ADR 0020 β€” run-rewind semantics for Spek recheck - #10804

Merged
hivecommons-hive[bot] merged 1 commit into
v6from
scanner/fix-10799
Oct 6, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v6from
scanner/fix-10799

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #10799
Part of #10734

This adds a v6 addendum to src/docs/adr/0020-spek-continuous-convergence.md that records the run-rewind design before any code changes. It also adds the missing ADR-0020 (Spek) line to the ADR index. This is a docs-only change, so it has no changelog fragment (changelog.d/README.md exempts docs-only changes).

The addendum sets four rules, R1–R4:

  • R1, rewind: a recheck bumps Revision and resets the existing run to spec. It no longer creates a sibling archive or a RevisionOf link. Earlier generations' receipts, proofs and outcomes are kept and never overwritten: the hub gen keeps increasing across generations. Only the current generation determines status. CampaignRevisionHistory becomes the generation log, with one entry per rewind recording the reason, actor, timestamp, last gen and a drift snapshot.
  • R2, in-flight: a recheck is in flight when the revise CampaignLease{Surface: \"revise\"} on the run's archive is live, or when Drift != nil and the campaign has not completed. Drift is cleared when the rewound generation completes. Its snapshot is already in the generation log.
  • R3, lease model: the rewound spec stage uses the run's own key, <repo>!<runKey>:spec with task run-admit-<runKey>. The second lease (<revision.ID>:spec, spek-recheck-*) is removed. A recheck that arrives while one is in flight gets a 409, or is skipped on the cadence tick, and creates no generation.
  • R4, API: RevisionOf stays on v6 for one release. It is deprecated, omitempty and always empty; legacy chain dedupe still reads it. It is removed from the API in the next release line, and the UI renders no sibling link.

Design owner: the maintainer who approves and merges this PR is the design owner that #10799's acceptance criteria call for. #10800 (recheck core) and #10801 (outward discovery) implement these rules.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson

…recheck

Signed-off-by: scanner <scanner@hive.kubestellar.io>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 6, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: held for human review. Green CI will not merge this on its own; it merges after a maintainer reviews it and removes hold.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10802 🌱 sync: forward-merge v5 into v6 (top-up), renumber planning-engine ADR to 0022 CONFLICT src/docs/adr/README.md

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 6, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit b2c603c into v6 Oct 6, 2026
65 of 68 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-10799 branch October 6, 2026 05:33
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants