Skip to content

🐛 fix: refuse automated claims on needs-human issues (takeover) - #10751

Merged
clubanderson merged 6 commits into
v5from
fix/10526-needs-human-claim-takeover
Oct 6, 2026
Merged

🐛 fix: refuse automated claims on needs-human issues (takeover)#10751
clubanderson merged 6 commits into
v5from
fix/10526-needs-human-claim-takeover

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #10526

Supersedes #10533 — carries @mendezr's commits with authorship preserved; rebased onto v5 and coverage floor restored.

Changes beyond the original:

  • Resolved the v5 conflict with [fix] claim gate: escalate instead of re-claiming after 2 no-progress claims #10527 by preserving kick delivery as a non-commenting listing and gating the agent start-signal claim instead.
  • Treat a missing GitHub client as a failed admission lookup, leaving automated claims unchanged rather than admitting on unknown labels.
  • Updated the cmd/hive admission test to cover the v5 listing-to-start flow.
  • Added targeted pkg/github coverage for failed claim-gate lookups and no-client admission failures.
  • Replaced the blocked-claim poller test's fixed sleep with testutil.Eventually to satisfy the sleep ratchet.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 6, 2026
@clubanderson clubanderson mentioned this pull request Oct 6, 2026
Closed
@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2026
@clubanderson clubanderson changed the title 🐛 fix: refuse automated claims on needs-human issues (takeover of #10533) 🐛 fix: refuse automated claims on needs-human issues (takeover) Oct 6, 2026
@clubanderson
clubanderson force-pushed the fix/10526-needs-human-claim-takeover branch from 926a82f to 76c016f Compare October 6, 2026 01:35
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10533 🐛 fix: refuse automated claims on needs-human issues same files changelog.d/fixed-needs-human-issue-claims.md
src/cmd/hive/claims_admission_test.go
src/cmd/hive/claimswire.go
src/cmd/hive/main.go
src/pkg/claims/admission_test.go
src/pkg/claims/claims.go
src/pkg/dashboard/blocked_claims_loop_test.go
src/pkg/dashboard/contribute_claim_gate_test.go
src/pkg/dashboard/contribute_claims.go
src/pkg/dashboard/contribute_ws.go
src/pkg/github/issue_claim_gate.go
src/pkg/github/issue_claim_gate_test.go
src/pkg/github/issue_request_watcher.go
src/pkg/github/issue_request_watcher_test.go
src/pkg/github/repo_pause_test.go

mendezr and others added 4 commits October 5, 2026 21:36
@mendezr @clubanderson
🐛 fix: refuse automated claims on needs-human issues
2a415a9 
Gate automated ledger claims, renewals and takeovers on current GitHub labels. Apply the same gate to claim requests and relay claim markers, and release blocked automated claims on the cleanup tick while preserving human claims and concurrent takeovers.

Hive-Run: #10526
Hive-Plan: needs-human-claim-gate
Hive-Spec: issue-10526#acceptance
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <407614+clubanderson@users.noreply.github.com>
@mendezr @clubanderson
fix: isolate blocked-claim polling and update watcher fixture
e96fec1 
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <407614+clubanderson@users.noreply.github.com>
@mendezr @clubanderson
test: cover blocked-claim poller release and shutdown
9368503 
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <407614+clubanderson@users.noreply.github.com>
@clubanderson
🐛 fix: adapt needs-human admission to v5 listings
3f186f6 
Keep kick delivery as a non-commenting listing on v5 and let the start-signal path perform the gated automated claim. Treat a missing GitHub client as a failed lookup so automated claims never admit on unknown labels.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <407614+clubanderson@users.noreply.github.com>
@clubanderson
clubanderson force-pushed the fix/10526-needs-human-claim-takeover branch from 76c016f to 3f186f6 Compare October 6, 2026 01:36
@clubanderson
test: cover failed needs-human claim lookups
982112b 
Exercise the no-client admission path and the issue-request retry path so unknown forge labels never become write permission.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <407614+clubanderson@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2026
@clubanderson

clubanderson commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

/lgtm
/approve

@kubestellar-prow

kubestellar-prow Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@clubanderson: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow

kubestellar-prow Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2026
@clubanderson clubanderson added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2026
@clubanderson
test: use Eventually for blocked claim poller
39d5024 
Avoid increasing the fixed-sleep test ratchet while preserving the blocked-claim cleanup assertion.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <407614+clubanderson@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2026
@kubestellar-prow

kubestellar-prow Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@kubestellar-prow kubestellar-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 6, 2026
@hivecommons-hive

hivecommons-hive Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

  • Claimed issue: hive#10527
  • Closing PR: #10736

A different merged PR closed the claimed issue. Leaving this contributor PR open for a human to review.

This comment is edited in place by the supersession sweep; it is not duplicated.

@clubanderson

clubanderson commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

/lgtm

@kubestellar-prow

kubestellar-prow Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@clubanderson: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@clubanderson clubanderson added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2026
@clubanderson
clubanderson merged commit 7841757 into v5 Oct 6, 2026
57 of 59 checks passed
@clubanderson
clubanderson deleted the fix/10526-needs-human-claim-takeover branch October 6, 2026 01:52
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

This was referenced Oct 6, 2026
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[fix] claim gate: refuse to claim issues labelled needs-human

2 participants

@clubanderson @mendezr