Repository navigation
🐛 fix: keep ready-work end marker inside queue scroll area - #10701
Conversation
Hive-Run: hivecommons#10681 Hive-Plan: queue-end-scroll-container Hive-Spec: hivecommons#10681#expected-behavior Signed-off-by: arteeh <arteeh@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Read the surrounding CSS/JS, not just the diff. This looks correct to me.
- The only scroll-dependent behaviour on
#cc-queuewas theoverflow-y:autorule atcontribute_landing.go:968and the menuboundary:btn.closest('.cc-queue')at:6264— both are moved to the new.cc-queue-scrollwrapper. I grepped forscrollTopand other.cc-queuereferences::993-994(.cc-queue.cc-q-draggable …) and:6018/:6756-6759(row lookups by#cc-queue) are unaffected since the#cc-queueelement itself keeps its id and class. #cc-q-endstays a sibling of#cc-queue, outside the row mount whoseinnerHTMLis replaced on poll, soccRenderQueueEndoutput survives re-renders as before.- Hunks don't overlap with #10700 or #10703 (same file, lines ~5614 and ~7396), so the three can land in any order.
One note, not a defect: the diff fully fixes #10681, so the body should say Closes #10681 rather than Refs — otherwise the issue stays open after merge.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Summary
The Ready-work queue displayed “End of queue reached” below its scrolling rows even when more rows remained out of view. Put the rows and end marker in a shared scroll container so the marker and managed-limit settings follow the last row. Keep the marker outside the row mount so queue refreshes preserve it, and use the shared scroll container as the row-menu positioning boundary.
Related issues
Refs #10681. Reporter confirmation is still needed after deployment.
Testing
gofmt -lon changed Go files: no output.Contributor checklist
v5.— hive: backend=codex model=gpt-6-astra effort=medium
🐝 Hive Agent:
contributor| SHA:077610f00