Skip to content

🐛 fix: keep ready-work end marker inside queue scroll area - #10701

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
arteeh:fix/10681-queue-end
Oct 5, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
arteeh:fix/10681-queue-end

Conversation

@arteeh

@arteeh arteeh commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Summary

The Ready-work queue displayed “End of queue reached” below its scrolling rows even when more rows remained out of view. Put the rows and end marker in a shared scroll container so the marker and managed-limit settings follow the last row. Keep the marker outside the row mount so queue refreshes preserve it, and use the shared scroll container as the row-menu positioning boundary.

Related issues

Refs #10681. Reporter confirmation is still needed after deployment.

Testing

  • Added a rendered-DOM regression test requiring the rows and following end marker to share the overflow container; the previous markup fails this assertion.
  • Updated the row-menu boundary regression expectation.
  • gofmt -l on changed Go files: no output.
  • Tests not run locally per AGENTS.md; CI runs validation. Browser verification has not been performed.

Contributor checklist

  • Added a changelog fragment.
  • Targets v5.
  • Title follows the repository emoji convention.
  • Commit includes matching DCO sign-off and Hive trailers.
  • No secrets or local runtime state committed.

— hive: backend=codex model=gpt-6-astra effort=medium


🐝 Hive Agent: contributor | SHA: 077610f00

Hive-Run: hivecommons#10681
Hive-Plan: queue-end-scroll-container
Hive-Spec: hivecommons#10681#expected-behavior
Signed-off-by: arteeh <arteeh@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 5, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the surrounding CSS/JS, not just the diff. This looks correct to me.

  • The only scroll-dependent behaviour on #cc-queue was the overflow-y:auto rule at contribute_landing.go:968 and the menu boundary:btn.closest('.cc-queue') at :6264 — both are moved to the new .cc-queue-scroll wrapper. I grepped for scrollTop and other .cc-queue references: :993-994 (.cc-queue.cc-q-draggable …) and :6018/:6756-6759 (row lookups by #cc-queue) are unaffected since the #cc-queue element itself keeps its id and class.
  • #cc-q-end stays a sibling of #cc-queue, outside the row mount whose innerHTML is replaced on poll, so ccRenderQueueEnd output survives re-renders as before.
  • Hunks don't overlap with #10700 or #10703 (same file, lines ~5614 and ~7396), so the three can land in any order.

One note, not a defect: the diff fully fixes #10681, so the body should say Closes #10681 rather than Refs — otherwise the issue stays open after merge.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10716 🐛 fix: Most effective models filters, run rates and local-registry labels same files src/pkg/dashboard/contribute_landing.go
#10700 🐛 fix: handle unexpected Hub decisions API responses same files src/pkg/dashboard/contribute_landing.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant