Repository navigation
🐛 dashboard: upgrade bees clipped behind topbar pill and version popover tile - #10674
Merged
Merged
Conversation
kubestellar-prow
Bot
added
the
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/M
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression
Likely introduced when the navbar upgrade bee landed in #10606 / commit 2625777, which added
overflow: hiddento the bee host surfaces; #10663 then widened the version popover where the clipping became visible.Tests
cd src && gofmt -l .(reports pre-existing unformatted files outside this change; changed test file is gofmt-clean)cd src && GOMODCACHE=/Users/andan02/.gomodcache-andan go vet ./pkg/dashboard/cd src && GOMODCACHE=/Users/andan02/.gomodcache-andan go test ./pkg/dashboard -short -count=1 -run 'Bee|Upgrade|Version|Topbar'cd src && GOMODCACHE=/Users/andan02/.gomodcache-andan go test ./pkg/dashboard/webstatic -short -count=1