Repository navigation
π dashboard: overview window pills overlap tiles β use in-flow toolbar like throughput - #10673
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
There was a problem hiding this comment.
Read the diff against the tree, not just the hunk. Looks correct to me.
What I verified:
.overview-kpishad exactly two references inindex.html(CSS at :1787 and the render at :13655), so movingsec-headline/data-collapsed-keepto the new.overview-headlinewrapper changes nothing for the collapse code βcollapsedKeepSelector()at :6365 still matches the wrapper and keeps toolbar + tiles together..overview-kpi-rangeis still used by the Review Queue pills (:5700). Droppingposition: absolutefrom it is harmless there:.review-queue-collapsed-range { position: static }(:3915) already overrode it, andreview_queue_view_9607_test.go:34still findsoverview-kpi-range-btn..prt-window-controlskeeps its class (:17481) so the renamed CSS rule is additive;pr_throughput_ui_test.gois updated to match.overview_kpi_sparklines_test.go:142stubsoverviewKPIWindowControlsand is unaffected.
No findings.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
.window-pills-toolbarstyle used by Overview and PR Throughput window pillsAudit
Tests
gofmt -l pkg/dashboard/overview_window_toolbar_test.go pkg/dashboard/pr_throughput_ui_test.goGOMODCACHE=/Users/andan02/gomodcache-andan go vet ./pkg/dashboard/GOMODCACHE=/Users/andan02/gomodcache-andan go test ./pkg/dashboard -short -count=1 -run 'Overview|Throughput|Window|Pill|Toolbar'GOMODCACHE=/Users/andan02/gomodcache-andan go test ./pkg/dashboard/webstatic -short -count=1