Skip to content

πŸ› dashboard: overview window pills overlap tiles β€” use in-flow toolbar like throughput - #10673

Merged
clubanderson merged 3 commits into
v5from
fix/overview-window-pills-inflow
Oct 5, 2026
Merged

clubanderson merged 3 commits into
v5from
fix/overview-window-pills-inflow

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

  • move Overview KPI window pills into an in-flow toolbar row above the KPI tile grid
  • extract a shared .window-pills-toolbar style used by Overview and PR Throughput window pills
  • add render-contract coverage that pins the shared toolbar and prevents Overview absolute positioning regressions

Audit

  • Converted: Overview KPI window pills.
  • Standardized shared style on: Overview and PR Throughput.
  • Checked Governor, Agents, Tokens, Cost, and other window/filter controls; no other absolutely positioned window/filter pill groups were found that overlap tiles.

Tests

  • gofmt -l pkg/dashboard/overview_window_toolbar_test.go pkg/dashboard/pr_throughput_ui_test.go
  • GOMODCACHE=/Users/andan02/gomodcache-andan go vet ./pkg/dashboard/
  • GOMODCACHE=/Users/andan02/gomodcache-andan go test ./pkg/dashboard -short -count=1 -run 'Overview|Throughput|Window|Pill|Toolbar'
  • GOMODCACHE=/Users/andan02/gomodcache-andan go test ./pkg/dashboard/webstatic -short -count=1

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible β€” a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking β€”
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly β€” that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10674 πŸ› dashboard: upgrade bees clipped behind topbar pill and version popover tile same files src/pkg/dashboard/static/index.html
#10675 πŸ› sync issue claim labels same files src/pkg/dashboard/static/index.html

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the tree, not just the hunk. Looks correct to me.

What I verified:

  • .overview-kpis had exactly two references in index.html (CSS at :1787 and the render at :13655), so moving sec-headline/data-collapsed-keep to the new .overview-headline wrapper changes nothing for the collapse code β€” collapsedKeepSelector() at :6365 still matches the wrapper and keeps toolbar + tiles together.
  • .overview-kpi-range is still used by the Review Queue pills (:5700). Dropping position: absolute from it is harmless there: .review-queue-collapsed-range { position: static } (:3915) already overrode it, and review_queue_view_9607_test.go:34 still finds overview-kpi-range-btn.
  • .prt-window-controls keeps its class (:17481) so the renamed CSS rule is additive; pr_throughput_ui_test.go is updated to match.
  • overview_kpi_sparklines_test.go:142 stubs overviewKPIWindowControls and is unaffected.

No findings.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit feda500 into v5 Oct 5, 2026
62 of 63 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/overview-window-pills-inflow branch October 5, 2026 19:02
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant