Repository navigation
π hub: restore node stats for pull-only clusters via heartbeat health; neutral awaiting-heartbeat state - #10567
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #10559
Root cause
Pull-only clusters intentionally make
buildSingleClusterHealthreturnerrClusterPullOnly, after which the hub falls back tos.heartbeatHealth[clusterID]. The hub stores heartbeat health under the resolved registry/SaaSentry.ClusterID, but current vllm-d spokes were heartbeating without a cluster health report: the spoke only populatedClusterHealthwhen theHIVE_CLUSTER_IDenvironment variable was set, even though boot had already resolved the effective cluster ID from config or env intob.cfg.Hub.ClusterID.Live evidence from the hub showed vllm-d spokes heartbeating every ~2 minutes, repeated pull-only cluster-health queries for
vllm-d, and nocluster health: using heartbeat fallback/ stored health forvllm-din the sampled logs. The vllm-d kube context was not reachable from this workstation, matching the pull-only design.Fix
HIVE_CLUSTER_IDis present.status/notefields for per-cluster health states.pull-only Β· awaiting spoke heartbeat, including last registry heartbeat age when known.Validation
gofmt -lon changed Go filesgit diff --checkgo test/go build; CI is the required verifier.