Skip to content

✨ hub dashboard: NPS feedback gets its own collapsible section above Users - #10562

Merged
clubanderson merged 3 commits into
v5from
feat/hub-nps-section-10558
Oct 5, 2026
Merged

✨ hub dashboard: NPS feedback gets its own collapsible section above Users#10562
clubanderson merged 3 commits into
v5from
feat/hub-nps-section-10558

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 5, 2026

Copy link
Copy Markdown
Member

Summary

  • moved hub admin NPS feedback into its own collapsible section above Users
  • added a collapsed NPS summary headline and kept admin-only/empty-state handling
  • updated dashboard markup tests for section placement

Closes #10558

Validation

  • gofmt -w src/pkg/hub/nps_test.go
  • git diff --check
  • Not run: go test/go build (AGENTS.md forbids local suite/build; CI is authoritative)

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 5, 2026
@kubestellar-prow

kubestellar-prow Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10580 🐛 hub: pull-only clusters use heartbeat health; neutral awaiting-heartbeat state same files src/pkg/hub/assets/dashboard.html

clubanderson added a commit that referenced this pull request Oct 5, 2026
@clubanderson @github-actions
changelog: fragment for #10562
e91fb83 
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Merged
@clubanderson
clubanderson force-pushed the feat/hub-nps-section-10558 branch from e91fb83 to 0681077 Compare October 5, 2026 13:58
clubanderson added a commit that referenced this pull request Oct 5, 2026
@clubanderson @github-actions
changelog: fragment for #10562
8a83440 
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Closed
@clubanderson
✨ hub dashboard: move NPS feedback section
31e65a4 
Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the feat/hub-nps-section-10558 branch from 8a83440 to 31e65a4 Compare October 5, 2026 14:09
clubanderson and others added 2 commits October 5, 2026 14:09
@clubanderson
Merge 31e65a4 into f410bd1
363a10b
@clubanderson @github-actions
changelog: fragment for #10562
cbd5399 
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@clubanderson
clubanderson merged commit dff5577 into v5 Oct 5, 2026
60 of 61 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/hub-nps-section-10558 branch October 5, 2026 14:25
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

This was referenced Oct 5, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

✨ hub dashboard: move NPS feedback into its own collapsible section above Users

1 participant

@clubanderson