Skip to content

[scanner] chore: remove unwired scripts/netlify-ignore.sh leftover #408

Closed

Description

@hivecommons-hive

Summary

scripts/netlify-ignore.sh is dead code. It is a Netlify "ignore builds" hook that skips deploy previews for chore/hive-snapshot* branches, but nothing invokes it:

  • netlify.toml has no ignore = … directive in [build] or any context (grep -rn netlify-ignore only matches the script's own echo lines).
  • No workflow, npm script, or doc references it.
  • The repository has no chore/hive-snapshot* branch (GET /repos/hivecommons/docs/branches?per_page=100 → 0 matches), and nothing else in the tree mentions hive-snapshot.
  • git log -S netlify-ignore --all shows the file arrived in the initial import commit (8faecb3) and has never been wired since — it is a leftover from the upstream site this repo was forked from, in the same category as the issue-form leftovers removed in fix(templates): drop KubeStellar leftovers from issue forms #404.

Expected

Either the script is wired ([build] ignore = "bash scripts/netlify-ignore.sh") because the snapshot-branch skip is wanted, or it is removed so the tree does not carry an unused deploy hook that readers assume is active.

Decision taken by hive

Remove the script. The branch pattern it guards does not exist in this repository, so wiring it would be a no-op, and removing it is deploy-safe even if a Netlify UI "ignore builds" setting still names it (a missing ignore command exits non-zero, which Netlify treats as "build").

Acceptance

  • scripts/netlify-ignore.sh deleted.
  • grep -rn netlify-ignore (excluding .git/node_modules) returns nothing.
  • No netlify.toml change.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. hivecommons-hive commented on Oct 21, 2026

    @hivecommons-hive
    ContributorAuthor

    Consolidated finding. This was filed as a separate issue; it references exactly the same files as this one (netlify.toml, scripts/netlify-ignore.sh), so it was folded in here instead. Address it in the same PR as this issue — two PRs editing the same files would conflict.

    Review backlog (correctness): Netlify deploy-preview failure is pre-existing, not introduced by this PR

    Filed from an out-of-scope finding in the Hive review of PR #409.

    PR: #409 (#409)
    Perspective: correctness
    Severity: info (P3)
    Evidence: netlify.toml:4 (

    [build]
    )
    Finding: Netlify deploy-preview failure is pre-existing, not introduced by this PR

    The netlify/hivecommons-docs/deploy-preview check fails on this PR, but it also fails on PRs 399, 404, 405 and 407 at their head SHAs (commit status API), so it is a baseline failure unrelated to deleting scripts/netlify-ignore.sh. netlify.toml at head has no ignore = directive and the build command does not reference the script.

    Fingerprint: a16883363fa96481111a85630ae7c7416a61f5c598ad20e2d253e839e8eb1f96

    filed by Hive review backlog

  2. hivecommons-hive commented on Oct 21, 2026

    @hivecommons-hive
    ContributorAuthor

    Linked again from the Hive review of PR #409.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions