Repository navigation
fix(build): fail prebuild when content sync fails unless DOCS_SYNC_OPTIONAL=1 - #240
Conversation
…TIONAL=1 Signed-off-by: scanner <scanner@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
…xt ProcessEnv augmentation Signed-off-by: scanner <scanner@hive.kubestellar.io>
|
hive/awaiting-ci: pushed typecheck fix (Next.js augments 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Read the diff against the tree at 06ab623, ran the new vitest file (4/4 pass), and exercised run-sync-step.ts directly. This looks correct to me and does what #239 asked: strict by default, opt-in fallback via DOCS_SYNC_OPTIONAL=1, and the PR body matches the diff.
One low-severity gap, verified by running it:
scripts/run-sync-step.ts:25—const status = result.status ?? 1;discardsresult.error. WhenspawnSyncitself fails (e.g.tsxnot onPATH, ENOENT),statusisnull, the script returns 1, and nothing is printed in strict mode — the build just dies with npm's generic exit-code message. Reproduced withPATHlackingnode_modules/.bin:exit=1and no output. Undernpm run buildthis won't happen (npm prependsnode_modules/.bin), so it only bites someone invoking the step by hand. Suggestif (result.error) console.error(result.error.message)before the status check.
Not a defect, just for the maintainer's awareness: with this change a transient raw.githubusercontent.com failure in sync-hive-docs.ts:237 / sync-sibling-docs.ts:447 now fails a Netlify production deploy rather than shipping committed content. That is exactly the trade-off #239 requested, so I'm noting it rather than objecting.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
…t 2, exit-code propagation) (#243) The prebuild gate from #240 had its entry block (lines 37-42) untested; only the exported helpers were exercised via an injected fake spawn, and the spawn invocation shape was never asserted. Drive the entry in process (vi.mock node:child_process, process.exit stub, vi.resetModules + dynamic import) following check-internal-links.main.test.ts so v8 attributes the coverage to the script. run-sync-step.ts goes 61.5% -> 100% lines. Closes #242 Signed-off-by: quality <quality@hive.kubestellar.io> Co-authored-by: quality <quality@hive.kubestellar.io> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Closes #239
prebuildno longer masks sync failures with|| echo. Each sync step runs throughscripts/run-sync-step.ts: strict by default (CI/Netlify fail on error); setDOCS_SYNC_OPTIONAL=1to explicitly fall back to committed content locally. Documented in CONTRIBUTING.md, with a unit test and changelog fragment.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88