Repository navigation
test: cover run-sync-step CLI entry in process (argv guard, usage exit 2, exit-code propagation) - #243
Merged
Conversation
…t 2, exit-code propagation) The prebuild gate from #240 had its entry block (lines 37-42) untested; only the exported helpers were exercised via an injected fake spawn, and the spawn invocation shape was never asserted. Drive the entry in process (vi.mock node:child_process, process.exit stub, vi.resetModules + dynamic import) following check-internal-links.main.test.ts so v8 attributes the coverage to the script. run-sync-step.ts goes 61.5% -> 100% lines. Closes #242 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
scripts/run-sync-step.main.test.ts, which drives the CLI entry ofscripts/run-sync-step.ts(the prebuild sync gate from #240) in process — the same techniquescripts/check-internal-links.main.test.tsuses — so v8 attributes coverage to the script itself:vi.mock("node:child_process")so no realtsxchild is spawnedprocess.exitstubbed to throw,process.argvset per case,vi.resetModules()+ dynamic importSeven cases: library import is a no-op; missing argument → usage + exit 2; success spawns
tsx <script>withstdio: "inherit"/env: process.env/ platform-correctshelland exits 0; child exit 3 propagates; signal-killed child (statusnull) → exit 1;DOCS_SYNC_OPTIONAL=1tolerates failure with the exact warning text;DOCS_SYNC_OPTIONAL=truedoes not.scripts/run-sync-step.tslinesFull suite: 89 files / 865 tests green;
eslint,tsc --noEmit,prettier --checkclean. No production code touched.Closes #242
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88