test: cover sync-sibling-docs main(), asset copying and introduceSpekStyle - #154
Merged
Merged
Conversation
…Style Spawn the script under tsx with a --import fetch stub (the pattern already used by update-meeting-recordings.test.ts) to exercise the prebuild sync end to end: required-readme failure, optional 404 skip, synced header and link rewriting on disk, *_DOCS_REF branch overrides, MDX image copy with site fallback and the outDir traversal guard. Add in-process unit tests for introduceSpekStyle. Closes #153 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
scripts/sync-sibling-docs.main.test.ts, driving the prebuild sibling-docs sync end to end the waynpm run prebuilddoes: the script is spawned undertsxwith a--importpreload that replacesglobalThis.fetch(the same patternupdate-meeting-recordings.test.tsalready uses), so no network is touched and every fetch outcome is scripted per URL.Covered:
not founderror; projects listed earlier are still written, later ones are not attempted— skippedand every required readme is still written*_DOCS_REFoverrides change the branch that is fetched and recorded in the headerspektacular-website: fetched images are copied underdocs/content/spektacular/images/…, missing images fall back to thesiteBaseURL, and a/images/../../…path is refused by theoutDirguard (never fetched, never written)introduceSpekStyle: non-spektacular and no-table targets are untouched,replaceAllrewrites every occurrence, backticked command names are preserved, the getting-started table appliesMutation check: removing the traversal guard makes the MDX test fail. Also adds a
changelog.dfragment.In-process v8 coverage for
scripts/sync-sibling-docs.tsmoves 32.65% → 39.79% statements (introduceSpekStyle);main/copyAssets/renderPagerun in the spawned child, which v8 does not instrument — the same limitation as the existing script tests.npx vitest run scripts/→ 10 files, 116 tests pass;eslintandtsc --noEmitclean.Closes #153
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88