-
Notifications
You must be signed in to change notification settings - Fork 3
[quality] src/app/docs/layout.tsx (site metadata + JSON-LD graph) has 0% test coverage #169
Copy link
Copy link
Closed
Labels
agent/qualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehive/hosted-available-oke-11-placeholder-r05xCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationHive verified that a merged PR references or claims this issue; pending confirmationqualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance
Description
Activity
Metadata
Metadata
Assignees
Labels
agent/qualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehive/hosted-available-oke-11-placeholder-r05xCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationHive verified that a merged PR references or claims this issue; pending confirmationqualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance
Finding
src/app/docs/layout.tsx(160 lines) is at 0% statement coverage in the Vitest suite — the only remaining 0% file undersrc/app/docs/after #158/#159 and #154.It is not a trivial shell: it owns the site-wide SEO surface for docs.hivecommons.dev —
metadataexport:metadataBase, canonical/docs, Open Graph (url,siteName, 1200×630 image), Twitter card,robots: { index, follow }, and thekeywordslist of integration names;<head>viadangerouslySetInnerHTML— twoSoftwareApplicationentries (Hive, Spektacular) and theHive CommonsOrganizationwith itssponsor/funderlists.A typo in
SITE_URL, a dropped@context, a sponsor without aurl, or a mismatch betweenmetadata.keywordsand the Hive entry'skeywordsstring would ship with no test failing. The hive/integrations JSON-LD in[...slug]/page.tsxalready has a test (docs-slug-page.params-metadata.test.tsx); the root layout's graph does not.Evidence
npx vitest run --coverageat39b6472→src/app/docs/layout.tsx | 0 | 0 | 0 | 0 | 11-160; suite total 82.56% lines / 778 tests..github/workflows/vitest.ymlis the only test workflow), so no e2e evidence exists either way.Recommendation
Add
src/__tests__/docs-layout.metadata-jsonld.test.tsxthat:next/font/local,next-themes,globals.cssand the chrome components (DocsNavbar/DocsFooter/DocsProvider/MobileOverlay), following theSlugLayoutpattern indocs-slug-page.params-metadata.test.tsx;metadataexport (origin, canonical, OG/Twitter parity, image dimensions, robots, keyword set);renderToStaticMarkup, extracts andJSON.parses the ld+json script, and asserts the three schema.org entries, Apache-2.0 license + hivecommonscodeRepository,sponsor === funderwith https urls, and that Hive'skeywordsstring equalsmetadata.keywords;<html lang="en">/ font-variable body classes and child ordering.Priority
Filed by quality agent (ACMM L4/L6 — full mode)
🐝 Hive Agent:
quality| Instance:hosted-available-oke-11-placeholder-r05x| SHA:39b6472— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88