Repository navigation
Groundwork: make the source a cargo workspace - #157
Merged
Merged
Conversation
A byte guard records every frame and short command the builders emit for a fixed list of calls, a CLI guard records the help text of every subcommand, and the release dry run lists the files of every package. The workspace move must leave all three unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Taken from the package-contents artifact of the release dry run of this pull request: the files of the deb, rpm, Arch and tarball packages for both architectures. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The library modules move to crates/obsbot-device, models.rs as registry.rs, and the 0.13 CLI and daemon to crates/obsbot4linux, which keeps the package name, the binary and the package metadata. Version, rust-version and licence come from [workspace.package]. No behaviour change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146
Stacked on #156 (the guards): this branch starts from
fix/145-groundwork-guards, so the diff againstrebuildshows #156's commits too until #156 has landed. Only the last commit,Make the source a cargo workspace, belongs to this pull request. Task 2 of the groundwork plan.What changed
src/becomes two crates.crates/obsbot-device(packageobsbot-device, libraryobsbot_device) holdscamera,commands,device,error,frame,presets,state,status,streamingandregistry(wasmodels.rs).crates/obsbot4linuxholdsmain,cli,client,daemonandproto. Files move withgit mv; the two guard tests and their fixtures move into the crates'tests/.Cargo.tomlis a virtual manifest:[workspace.package](version 0.13.2, edition, rust-version, licence, authors, repository, homepage),[workspace.dependencies],[profile.release] strip = true.crates/obsbot4linux/Cargo.tomlkeeps the package name, the binary name and the deb / rpm metadata, with../../asset paths.lib.rsis laid out in four blank-line separated groups, one for each following task.usepaths:obsbot4linux::becomesobsbot_device::,modelsbecomesregistry. Nothing else in the Rust code changes.ci.ymlandrelease.ymluse--workspace;cargo deb -p obsbot4linux;cargo generate-rpm -p crates/obsbot4linux;crates/*/Cargo.tomlis added to the release dry-run paths filter.--workspace), one CHANGELOG line under Changed.Verification (local)
cargo fmt --check,cargo clippy --workspace --all-targets --locked -- -D warnings,shellcheck scripts/groundwork/*.sh scripts/package-contents.sh,actionlint .github/workflows/*.yml: no output.cargo test --workspace --locked: 118 passed (library), 1 passed (byte_guard), 25 passed (binary), 2 passed (cli_surface), 0 doc tests. Same 146 tests as before.scripts/groundwork/test-names.shfor the base (12d9e0d) and the head gives 146 names each;comm -3prints nothing.git diff -M --stat).scripts/groundwork/move-check.sh <base> HEADprints exactly the four changed code lines the plan lists (8 lines with the</>pairs):models::from_card/from_by_idtoregistry::,obsbot4linux::device::detectandobsbot4linux::state::pathtoobsbot_device::.git diff -M --statshows every moved file as a rename;device.rs6 lines,lib.rs13,byte_guard.rs6,cli.rs14,client.rs4,daemon.rs8 (use lines and the paths above).Cargo.lockdiff: adds theobsbot-deviceentry, changes the dependency list ofobsbot4linuxto clap, nix, obsbot-device, serde, serde_json. No other entry changes.cargo metadataexternal crates and versions: diff against before is empty.name,version,license,description,homepage,repository,authors,edition,rust_versionofobsbot4linux: diff empty.cargo tree -e normal,build,features -p obsbot4linux: external crates and features, diff against before empty (97 lines).cargo build --release --locked:file -b target/release/obsbot4linuxends in, stripped.contentsjob against the unchangedpackaging/contents.txt).🤖 Generated with Claude Code