Repository navigation
Groundwork: move the frame codec and the on-air probe to family - #158
Merged
Merged
Conversation
A byte guard records every frame and short command the builders emit for a fixed list of calls, a CLI guard records the help text of every subcommand, and the release dry run lists the files of every package. The workspace move must leave all three unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Taken from the package-contents artifact of the release dry run of this pull request: the files of the deb, rpm, Arch and tarball packages for both architectures. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The library modules move to crates/obsbot-device, models.rs as registry.rs, and the 0.13 CLI and daemon to crates/obsbot4linux, which keeps the package name, the binary and the package metadata. Version, rust-version and licence come from [workspace.package]. No behaviour change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
frame.rs and streaming.rs move unchanged; lib.rs keeps their old paths as re-exports until the final path change of the groundwork stage. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147
Stacked on #157 (base stays
rebuild; the diff of this pull request on top of #157 is the single commit shown here).What changed
crates/obsbot-device/src/frame.rsandstreaming.rsmove tocrates/obsbot-device/src/family/as pure renames (100% similarity, no content change).family/mod.rsdeclarespub mod frame; pub mod streaming;.lib.rs: only the grouppub mod frame; pub mod streaming;becomespub mod family; pub use family::{frame, streaming};, soobsbot_device::frameandobsbot_device::streamingstay valid until the final path change of the stage.No byte sent to the camera, no ioctl, no timing and no command-line output changes. No CHANGELOG line (no user-visible change).
Verification (no camera)
cargo fmt --check,cargo clippy --workspace --all-targets --locked -D warnings,shellcheck scripts/groundwork/*.sh scripts/package-contents.sh,actionlintprint nothing;cargo test --workspace --locked: 118 + 1 (byte_guard) + 25 + 2 (cli_surface) + 0 doc tests pass.scripts/groundwork/test-names.shfor base and head,comm -3prints nothing (146 names each).byte-guard.txtandcli-surface.txtare not in the diff.scripts/groundwork/move-check.sh <base> HEADprints exactly the SPDX line and the module doc line offamily/mod.rs.git diff -M --statshows both files as renames with 0 changed lines; four files in total.