Repository navigation
chore: saved workflows find the pull request themselves and stop closing umbrella issues - #313
Merged
Merged
Conversation
…ing umbrella issues nova-pr: after the builder returns, a light read-only agent lists the open pull requests of the task branch and that number is the source of truth. A builder without pr_number no longer drops the task; a differing number or no open pull request is refused with a clear reason. pr_number is required in the builder schema. New task field closes (default true): with false the builder writes "Refs #<n>", and a PR body that closes the issue makes the task not ready. Title errors name the slug and the rejected character. nova-merge-train cleanup: a remote branch that GitHub already deleted after the push is the expected outcome, not a problem. Both headers say scratch output goes under ~/.cache or the scratch argument, not /tmp. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
4 tasks
- nova-merge-train cleanup: drop the free-text goneOnly backstop; the structural plan already treats a gone remote branch as expected, so kept worktrees and refused deletions are reported again. - nova-builder role file: Refs instead of Closes when the task says the issue stays open. - Headers: ~/.cache instead of a local absolute path (R-PUBLIC). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #294
What changed
nova-pr.js: after the builder returns, a light read-only agent runsgh pr list --head <branch> --state openand the script uses that number as the source of truth. A builder that omitspr_numberno longer drops the task (it happened with ci: release only pull-request-green commits, changelog section required, publish draft-first #309 and feat: offer updates as a browser download instead of installing them inside the app #312). A differing builder number, several open PRs, a failed lookup or no open PR is refused with a reason.pr_numberis now required in the builder schema.nova-pr.js: new optional task fieldcloses(boolean, default true), validated and documented in the header andwhenToUse. Withcloses: falsethe builder prompt asks forRefs #<n>and forbids closing keywords; a PR body that closes the issue anyway makes the task not ready. There was no body gate before, so a small one was added (the facts agent also returns the body).nova-pr.js: the title error names the task slug and the rejected character.nova-merge-train.jscleanup: a remote branch already deleted by GitHub is the expected outcome (handled structurally by the cleanup plan, no text matching) and no longer produces a problem orpartial. The rule for a branch that still exists is unchanged (tip is the pushed head or already on origin/main)..claude/agents/nova-builder.md: rule 6 writesRefs #<n>instead ofCloses #<n>when the task says the issue stays open.~/.cacheor the scratch argument, not/tmp.Left out
nova-research.js,.github/, app code,.claude/settings.json, and the other open items of Follow-ups after the switch to fast-forward pushes #294.CLAUDE.mddoes not describe the changed behaviour, so it is untouched.Checked
node --checkon wrapped copies of both scripts; prettier check.pr_numberproceeds to review, number mismatch refused, no open PR refused,closes: falseprompt hasRefsand no closing keyword, already deleted remote branch givesdonewithout problems, differing remote tip kept and reported.🤖 Generated with Claude Code