Skip to content

Follow-ups after the switch to fast-forward pushes #294

Open

Description

@nofuturekid

Pull requests land by a fast-forward push since 2026-11-13 (#293; rulesets "main (no bypass)" and "main: pull request (admin push bypass)"). Left over:

  • .github/: comments and messages still describe squash merges (release.yml header and lookup comments, release-guard.sh messages, ci.yml header, codeql.yml, the (#NN) checkbox in PULL_REQUEST_TEMPLATE.md). Wording only, no functional change; waits until no pre-release is in acceptance.
  • nova-merge-train.js, cleanup mode: reports partial when GitHub already deleted the pull request's branch after the push. That is the expected case and should not count as a problem.
  • First release under the new flow: run the "Release dry run" from HANDOFF.md after pushing main and before pushing the tag. The lookup of the CI run by the tagged commit itself has not run in production yet.
  • Renovate pull requests: confirm on the first one that its rebase trigger works and that the pin check in the merge train covers it.

Proven on 2026-11-13: a push of an unchecked commit to main is refused (GH013, required status check build); a push of a pull request's green head commit is accepted, the pull request is marked merged and its branch is deleted.

🤖 Generated with Claude Code

Activity

  1. self-assigned this
    on Nov 13, 2026
  2. nofuturekid commented on Nov 13, 2026

    @nofuturekid
    CollaboratorAuthor

    Pull request #313 covers:

    • nova-merge-train.js cleanup: a remote branch already deleted by GitHub is no longer a problem (second item).
    • nova-pr.js: the pull request is established from the branch by the script, not from the builder's pr_number.
    • nova-pr.js: optional task field closes for umbrella issues (Refs #<n>, no closing keyword).
    • Smaller carry-overs: title error names slug and character; /tmp note in both headers.

    The other items stay open.

    🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentation

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions