Repository navigation
Port Playwright's frame page tests (Refs #1060) - #1070
Conversation
…t tests (Refs #1060) The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…e-hierarchy tests (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…rarchy ports (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…(Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
…ind and release held requests at exit (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…route bugs with 500 (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
#1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
Ports the frame tests of the Playwright page suite (34
it). They checkframeLocatorqueries, actions that wait for frames, and frame navigation, against Playwright's own frame assets.Upstream change ported: e2e-inc/e2e#1505 (
bdf769b), filesapps/testbed/tests/locator-frame.e2e.ts(17),selectors-frame.e2e.ts(13),frame-goto.e2e.ts(1),frame-hierarchy.e2e.ts(3). Assetsframes/*andshadow.htmlcome with it.Known differences kept as
ExpectedToFailAsync(they fail today and start failing the day the port is fixed):getByRolealso matches the nested frame's button: Frame-scoped getByRole also matches nodes of a nested frame (locator-frame, selectors-frame, #1060) #1066.gototimeout message has notimed out in browser.gotolabel: goto timeout message has no 'timed out in browser.goto' label (frame-goto, #1060) #1068 (waits for the label PR in the Upstream: Playwright's page tests in the testbed suite (#1505) #1060 plan).The three upstream
failtests about hidden iframes (#1067) pass in the port, so they run as normal tests.Partial ports (
Partial_prefix):should send "framenavigated" when navigating on anchor URLs(no frame events, checks the URL only) andshould report frame from-inside shadow DOM(nopage.frames(), checks the iframe through locators).Not ported, as upstream (feature missing in e2e): each file header lists them: element handles,
locator.frameLocator,contentFrame,any-frame, Frame objects and frame events,$eval..NET-only:
Helpers.CROSS(upstream'sCROSSis a fixed port; the port useslocalhoston the testbed's own port; the cross-origin test skips itself iflocalhostcannot bind),Helpers.AfterandHelpers.Record(upstream'sdelay(...).thenandfailure). The testbed answers Playwright routes on their own task and serves/never(upstreamroutes.mjs), because the listener loop was sequential and a held request would block every other one; held requests end at process exit or after 30 s.Refs #1060
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK