You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Upstream test: selectors-frame and locator-frame '$ and $$' / $eval tests #1166
Possible gap; check the upstream header comment before filing.
Upstream files:
apps/testbed/tests/selectors-frame.e2e.ts
apps/testbed/tests/locator-frame.e2e.ts
Missing in the port:
should work for $ and $$
should work for $eval
should work for $$eval
Port evidence:
No port method of those names in SelectorsFrame/ or LocatorFrame/. The upstream header may list them as not ported (Playwright-only API); not verified.
Found by an audit of tester-army/e2e at f185ca8 (#1582) against e2e-dotnet origin/maine8a1193. Confidence: medium. Check COMPATIBILITY.md and the upstream it before porting; port every missing it per CLAUDE.md.
Checked on main (61068ef): these tests are already ported. tests/E2E.NUnit.Tests/SelectorsFrame/SelectorsFrameTests.cs has all six non-handle tests (Should_work_for_Dollar_and_DollarDollar, Dollar_should_not_wait_for_frame, DollarDollar_should_not_wait_for_frame, DollarDollarEval_should_not_throw_for_missing_frame, Should_work_for_DollarEval, Should_work_for_DollarDollarEval), and LocatorFrame/LocatorFrameTests.cs has Should_work_for_Dollar_and_DollarDollar. Upstream's header skips only the handle variants. The audit likely searched for the literal name $ and $$. Suggest closing as already done (see #1070). No PR opened.
Activity
kblok commentedon Nov 6, 2026
An agent is working on this (open-issue-orchestrator).
kblok commentedon Nov 6, 2026
Checked on main (61068ef): these tests are already ported.
tests/E2E.NUnit.Tests/SelectorsFrame/SelectorsFrameTests.cshas all six non-handle tests (Should_work_for_Dollar_and_DollarDollar,Dollar_should_not_wait_for_frame,DollarDollar_should_not_wait_for_frame,DollarDollarEval_should_not_throw_for_missing_frame,Should_work_for_DollarEval,Should_work_for_DollarDollarEval), andLocatorFrame/LocatorFrameTests.cshasShould_work_for_Dollar_and_DollarDollar. Upstream's header skips only the handle variants. The audit likely searched for the literal name$ and $$. Suggest closing as already done (see #1070). No PR opened.kblok commentedon Nov 6, 2026
Closing as already ported (see #1070).