Skip to content

Upstream test: selectors-frame and locator-frame '$ and $$' / $eval tests #1166

Closed

Description

@kblok

Possible gap; check the upstream header comment before filing.

Upstream files:

  • apps/testbed/tests/selectors-frame.e2e.ts
  • apps/testbed/tests/locator-frame.e2e.ts

Missing in the port:

  • should work for $ and $$
  • should work for $eval
  • should work for $$eval

Port evidence:
No port method of those names in SelectorsFrame/ or LocatorFrame/. The upstream header may list them as not ported (Playwright-only API); not verified.

Related: #1060

Found by an audit of tester-army/e2e at f185ca8 (#1582) against e2e-dotnet origin/main e8a1193. Confidence: medium. Check COMPATIBILITY.md and the upstream it before porting; port every missing it per CLAUDE.md.

Activity

  1. kblok commented on Nov 6, 2026

    @kblok
    MemberAuthor

    An agent is working on this (open-issue-orchestrator).

  2. kblok commented on Nov 6, 2026

    @kblok
    MemberAuthor

    Checked on main (61068ef): these tests are already ported. tests/E2E.NUnit.Tests/SelectorsFrame/SelectorsFrameTests.cs has all six non-handle tests (Should_work_for_Dollar_and_DollarDollar, Dollar_should_not_wait_for_frame, DollarDollar_should_not_wait_for_frame, DollarDollarEval_should_not_throw_for_missing_frame, Should_work_for_DollarEval, Should_work_for_DollarDollarEval), and LocatorFrame/LocatorFrameTests.cs has Should_work_for_Dollar_and_DollarDollar. Upstream's header skips only the handle variants. The audit likely searched for the literal name $ and $$. Suggest closing as already done (see #1070). No PR opened.

  3. kblok commented on Nov 6, 2026

    @kblok
    MemberAuthor

    Closing as already ported (see #1070).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions