Skip to content

Post PR4475 fixes for Free to use only check box #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tonytw1 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Draft

Post PR4475 fixes for Free to use only check box #4651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions kahuna/public/js/search/query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,11 @@ query.controller('SearchQueryCtrl', [
// eslint-disable-next-line complexity
function watchSearchChange(newFilter, sender) {
let showPaid = newFilter.nonFree ? newFilter.nonFree : false;
if (sender && sender == "filterChange" && !newFilter.nonFree) {
showPaid = ctrl.user.permissions.showPaid;
if (ctrl.usePermissionsFilter) {
Copy link
Contributor Author

@tonytw1 tonytw1 Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the feature switch to bypass this new block restored the Back to search behaviour.

// Fixes Free to use only check-box is cleared on Back to search
if (sender && sender === "filterChange" && !newFilter.nonFree) {
showPaid = ctrl.user.permissions.showPaid;
}
}
storage.setJs("isNonFree", showPaid, true);

Expand Down Expand Up @@ -318,7 +321,7 @@ query.controller('SearchQueryCtrl', [
}

ctrl.sortProps = {
onSortSelect: updateSortChips,
onSelect: updateSortChips,
Copy link
Contributor Author

@tonytw1 tonytw1 Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bi-section,
reverting this line restored the logo click behaviour.

No idea why this is effective.
It could be something todo with the path into watchSearchChange been somehow bound to the state of the sort control?

query: $stateParams.query,
orderBy: ctrl.ordering ? ctrl.ordering.orderBy : ""
};
Expand Down
Loading