Post PR4475 fixes for Free to use only check box#4651
Post PR4475 fixes for Free to use only check box#4651tonytw1 wants to merge 1 commit intoguardian:mainfrom
Conversation
Fixes Free to use only check-box is cleared on Back to search Fixes Free to use only check-box sticks on icon click.
| let showPaid = newFilter.nonFree ? newFilter.nonFree : false; | ||
| if (sender && sender == "filterChange" && !newFilter.nonFree) { | ||
| showPaid = ctrl.user.permissions.showPaid; | ||
| if (ctrl.usePermissionsFilter) { |
There was a problem hiding this comment.
Using the feature switch to bypass this new block restored the Back to search behaviour.
|
|
||
| ctrl.sortProps = { | ||
| onSortSelect: updateSortChips, | ||
| onSelect: updateSortChips, |
There was a problem hiding this comment.
Using bi-section,
reverting this line restored the logo click behaviour.
No idea why this is effective.
It could be something todo with the path into watchSearchChange been somehow bound to the state of the sort control?
|
Breaks the sort by dropdown =( |
|
The way this fix for the checkbox breaks the sort drop down is interesting. Removing the The icon stays highlighted after click remains. Something about the |
1 participant
After rebasing up to this point, we found the behaviour of the Free to use only check box regressed.
Disclaimer; we are forked quite away from the main Grid so this may not reflect want happens in the main branch.
Provided FYI.
Back to search
With Free to use only checked,
clicking into an image then
click Back to search the Free to use only check box has lost it's state:
back-to-search.mov
Free to use only should have kept it's checked state
Logo click
With Free to use only checked and none of the other check boxes.
clicking on the Grid logo
Free to use only remains checked
and the next click to any of the check boxes is broken.
logo-click.mov
Free to use only should have reset to empty.
The other checkboxes should have worked as normal on the next click.
What does this change?
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?