Repository navigation
site: make every interactive part an explicit state machine - #4
Merged
Merged
Conversation
Interactive state was spread across booleans, timers, classes and DOM nodes, which caused races and stale UI. A small helper (assets/js/state-machine.js) gives each part one named state with guarded transitions, mirrored onto <html data-<name>-state> and listed by PortfolioState.snapshot(). - Overlay stack: Escape closes only the top overlay, one focus trap at a time - Fix confirmed bugs in the drawer, Clippy, labs, sims, copy and contact flows - docs/site/STATE.md documents every machine; new smoke test covers the fixes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site's interactive parts kept their state spread across booleans, timers, CSS classes and DOM nodes. That caused real bugs: one Escape closed every open layer at once, a stale Clippy popped back over the goose, "Copied Email" stuck on the button after a double click, and a lab's status said "running" after it had paused. It was also hard for people, tests and agents to tell what state anything was in.
Every interactive part is now an explicit state machine. A small helper,
assets/js/state-machine.js, gives each part one named state and a fixed set of allowed transitions. That state is mirrored onto<html>asdata-<name>-state, andPortfolioState.snapshot()returns all of them at once.docs/site/STATE.mdlists all 18 machines and the rules for adding one.What visitors get
For reviewers
photo-page.jsis intentionally untouched, because photo-page changes need the owner's approval first.photo.htmlonly gains the shared script tag.state-machine.jsloads beforesite-shell.json the homepage, the photo page and the Fly101 page.🤖 Generated with Claude Code
Created with Claude Opus 5.5 in Claude Code.