Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/scroller-on-mouse-down.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@graphcommerce/framer-scroller': patch
---

`useScroller` calls the `onMouseDown` of its props. It replaced it with its own handler, so a click on an image of `SidebarGallery` did not open the zoom.
41 changes: 41 additions & 0 deletions packages/framer-scroller/hooks/useScroller.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// @vitest-environment happy-dom

import { act } from 'react'
import { createRoot } from 'react-dom/client'
import { afterAll, beforeAll, expect, it, vi } from 'vitest'
import { Scroller } from '../components/Scroller'
import { ScrollerProvider } from '../components/ScrollerProvider'

beforeAll(() => {
Object.assign(globalThis, { IS_REACT_ACT_ENVIRONMENT: true })
})

afterAll(() => {
Reflect.deleteProperty(globalThis, 'IS_REACT_ACT_ENVIRONMENT')
})

it('calls the onMouseDown of its props', () => {
const onMouseDown = vi.fn()
const container = document.createElement('div')
document.body.appendChild(container)
const root = createRoot(container)

act(() =>
root.render(
<ScrollerProvider>
<Scroller onMouseDown={onMouseDown}>
<div>Item</div>
</Scroller>
</ScrollerProvider>,
),
)
act(() => {
container
.querySelector('.Scroller-root')
?.dispatchEvent(new MouseEvent('mousedown', { bubbles: true }))
})
act(() => root.unmount())
container.remove()

expect(onMouseDown).toHaveBeenCalledTimes(1)
})
1 change: 1 addition & 0 deletions packages/framer-scroller/hooks/useScroller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export function useScroller<
if (event.target.querySelector(':scope > input, :scope > textarea')) return
}
event.preventDefault()
divProps.onMouseDown?.(event as never)
}

const onPan: PanHandlers['onPan'] = (event, info: PanInfo) => {
Expand Down
Loading