Repository navigation
Call the onMouseDown of the Scroller props - #2697
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: a288741 The changes in this PR will be included in the next version bump. This PR includes changesets to release 87 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by 🤖:
useScrollerreturns its ownonMouseDownafter...divProps, so theonMouseDownof the props never runs.SidebarGallerypassesonMouseDownto itsScrollerto keep the start position of a click. Because that handler does not run, the start position stays 0, andonMouseUpopens the zoom only within 8 px of the left edge of the window. A click on a product image does not open the zoom.Scrollerwith anonMouseDownand sends amousedown. It failed on CI before the fix: the handler is not called.onMouseDownofuseScrollercalls theonMouseDownof the props. CI passes with it.