Skip to content

Option to remove filter with custom value#77

Open
ShilpaSivanesan wants to merge 1 commit into
grafana-druid-plugin:masterfrom
GoshPosh:filter_fix_custom_value
Open

Option to remove filter with custom value#77
ShilpaSivanesan wants to merge 1 commit into
grafana-druid-plugin:masterfrom
GoshPosh:filter_fix_custom_value

Conversation

@ShilpaSivanesan
Copy link
Copy Markdown

Adding "REMOVE_FILTER" as a custom value allows to disable the filter

For Example :

screen shot 2018-08-19 at 10 57 05 pm

In the above Image,
App "web" does not have any version listed in App Version filter. Choosing "All" will default give value as 0
, But applying this custom value eliminates being 0 for all and gives out the actual web count

@shcarrico
Copy link
Copy Markdown
Collaborator

I'm unclear why "All" should have a value at all. Shouldn't "All" remove the filter?

@shcarrico shcarrico self-requested a review September 5, 2018 08:03
@Gauravshah
Copy link
Copy Markdown
Collaborator

All is subjective from grafana perspective. All could mean all options listed or it could mean all of the data. grafana has left that to user's choice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants