Support removal of filter based on variable selection#76
Closed
Gauravshah wants to merge 22 commits into
Closed
Conversation
Period granularity
fix metrics autocomplete
added ability to edit filters
fixing display size for period selector
…values_with_latest_master # Conflicts: # dist/query_ctrl.js.map # dist/test/query_ctrl.d.ts # dist/test/query_ctrl.js # dist/test/query_ctrl.js.map
…t_master Filter values auto complete latest master
eye icon now hides metrics
…scoped_variables_master # Conflicts: # dist/datasource.js # src/datasource.js
…scoped_variables_master # Conflicts: # dist/datasource.js # src/datasource.js
check for hide first as per review & log it
…b.com:GoshPosh/druidplugin into enable_scoped_variables_master
Enable scoped variables master
…ed_master missed fix from commit 23f6034
fix start time bby rounding to day
added an option to ignore a filter when a predefined value is selected
adding filter.pattern for supporting regex
Collaborator
Author
|
working on cleaning commits |
Collaborator
Author
|
cleaner PR #77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variables are super powerful to create dynamic dashboards. One of the limitation was when selecting all we had to do
.*as regex , it worked in some cases and and some cases it wouldn't work.Removing the filter in case of all made most sense since we wanted all the values ( effectively removing filter itself)