Repository navigation
feat(modeldeployment): configure per-role shared memory - #748
Merged
Merged
Conversation
Add a positive shmSize quantity with a 16Gi rendered default. Preserve explicit mounts and existing Elastic members. Update generated APIs, render checks and the owning guides. Signed-off-by: thxCode <thxcode0824@gmail.com>
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). Reviewed |
Signed-off-by: thxCode <thxcode0824@gmail.com>
Collaborator
Author
|
Review round 1: checked all feedback buckets (0 reviews, 0 inline comments, 1 summary finding). The documentation finding is valid. The Elastic EP page now describes only its head/member mounts and replacement behavior. It links to the deployment configuration page for defaults, explicit mount precedence and memory budgeting.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
/kind api-change
/area worker
What this PR does / why we need it:
ModelDeployment roles cannot size their shared memory. Ordinary Pods use the container runtime default;
Elastic GPU members use a fixed 512Mi volume, and their CPU head has no default mount.
Add optional
roles[].shmSizeas a positive Kubernetes quantity. Render an isolated memory-backed/dev/shmvolume with a default limit of16Gifor ordinary roles, take-over roles, and Elastic head/master/workers.Preserve explicit
/dev/shmmounts inadditionalVolumes. Only the main container mounts the generated volume.Regenerate the API schema, protobuf, deepcopy, OpenAPI and apply configuration.
Which issue(s) this PR links to:
NONE
Special notes for your reviewer:
16Giis a project default, not a guarantee that every engine workload fits. Dynamic TP>1 inference remains unverified.make testpassed for 99 packages with race, shuffle and coverage. Focused controller/webhook tests,make lint,make lint docsand post-lint generation passed.Does this PR introduce a user-facing change?