Repository navigation
feat(modeldeployment): simplify elastic Ray admission - #749
Conversation
Signed-off-by: thxCode <thxcode0824@gmail.com>
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). Reviewed |
Signed-off-by: thxCode <thxcode0824@gmail.com>
|
Review round 1 read all feedback buckets: 1 submitted review, 2 inline comments and 1 summary comment. All 5 emitted items were checked.
The corrected head still has no resource requests/limits and no CPU InstanceType or queue dependency. Full CPU validation results are recorded in the PR description. No GPU runtime result is claimed. |
Signed-off-by: thxCode <thxcode0824@gmail.com>
Signed-off-by: thxCode <thxcode0824@gmail.com>
|
Review round 3 read all feedback buckets: 4 submitted reviews, 6 inline comments including prior replies, and 2 conversation comments. The latest review emitted 2 findings. No suppressed findings were present.
The usage guide keeps configuration and version requirements. Source evidence stays in the design record, as requested. Documentation lint and API generation were rerun. The runtime source is unchanged from the previously tested branch. |
What type of PR is this?
/kind enhancement
/kind api-change
/area worker
What this PR does / why we need it:
Elastic EP requires a CPU InstanceType and Kueue queue for its Ray head, although the head holds no GPU engine.
GPU members also declare Ray GPU capacity explicitly instead of discovering their allocated devices.
Remove
elasticEp.headInstanceTypeand render the independent head as an auxiliary Pod with no resource requests or limits.Keep its owner, Service, role identity, shared-memory policy, explicit privilege and uncached creation guard.
Remove
--num-gpusfrom GPU master/worker commands while preserving GPU requests and fixed TP.Keep
--num-gpus=0on the CPU head and reuse the existing Ray capacity and allocation checks.Read vLLM's startup
--elastic-ep-max-dp-sizefromextraArgsthrough the existing parser.Reject target widths above an explicit capacity and changes to that effective startup capacity after creation.
Omitted capacity preserves legacy admission. Regenerate all API artifacts and update the owning guide and resize spec.
Which issue(s) this PR links to:
Relates #748
Special notes for your reviewer:
make testpassed for 99 packages with race, shuffle and coverage. Code/docs lint and post-lint generation passed. Independent Standards and Spec review found no confirmed defects. PR review identified a missing privileged setting; its regression test failed before the fix and now passes. The complete 99-package suite passed again after that fix.Does this PR introduce a user-facing change?