Skip to content

Add size-gated hugepage optimization for large allocations #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsane-dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add size-gated hugepage optimization for large allocations #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tcmalloc/internal/system_allocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,15 @@ SystemAllocator<Topology, NormalPartitions>::MmapRegion::Alloc(
// This is only advisory, so ignore the error.
ErrnoRestorer errno_restorer;
(void)madvise(result_ptr, actual_size, MADV_NOHUGEPAGE);
} else {
// Opt-in to transparent hugepages for large allocations when system is
// configured for transparent_hugepage=madvise. This can improve memory
// performance by reducing TLB pressure.
if (actual_size >= kHugePageSize) {
// This is only advisory, so ignore the error.
ErrnoRestorer errno_restorer;
(void)madvise(result_ptr, actual_size, MADV_HUGEPAGE);
}
}
free_size_ -= actual_size;
return {result_ptr, actual_size};
Expand Down