Add size-gated hugepage optimization for large allocations#291
Open
hsane-dev wants to merge 1 commit intogoogle:masterfrom
Open
Add size-gated hugepage optimization for large allocations#291hsane-dev wants to merge 1 commit intogoogle:masterfrom
hsane-dev wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
hsane-dev
force-pushed
the
hugepage-optimization
branch
from
c562ce0 to
d24787f
Compare
This patch adds optional hugepage optimization by applying madvise(MADV_HUGEPAGE) to allocations that are large enough to benefit from transparent hugepages. Current behavior: - Uses MADV_NOHUGEPAGE for infrequent access patterns, MADV_HUGEPAGE only for memory collapsing - No proactive hugepages for large allocations Enhanced behavior: - Adds MADV_HUGEPAGE for allocations >= kHugePageSize (2MB) - Only applies to allocations that can actually benefit from hugepages - Avoids kernel overhead on small allocations The size threshold ensures we only hint hugepage usage for allocations that can actually be backed by hugepages, avoiding unnecessary kernel overhead for smaller allocations.
hsane-dev
force-pushed
the
hugepage-optimization
branch
from
d24787f to
f0bf91a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds proactive hugepage optimization to improve memory performance for allocations ≥2MB while preserving existing memory management behavior.
Changes
MmapRegion::Alloc()insystem_allocator.hto applyMADV_HUGEPAGEfor large allocations>= kHugePageSize) to avoid overhead on small allocationsMADV_NOHUGEPAGElogic for infrequent access patterns